cleanup(core): inline angular cli nested project migration logic into nx init #15396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
force-pushed
the
misc/nx-init-angular
branch
2 times, most recently
from
102f5ff
to
301ef6f
Compare
leosvelperez
requested review from
meeroslav,
barbados-clemens,
vsavkin,
FrozenPandaz and
AgentEnder
as code owners
barbados-clemens
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
e2e utils look good.
just a heads up as @mandarini is refactoring those so you'll probably have a merge conflict once that PR lands.
#15421
mandarini
approved these changes
Mar 3, 2023
leosvelperez
force-pushed
the
misc/nx-init-angular
branch
from
ec6b5ce
to
81e9b53
Compare
leosvelperez
force-pushed
the
misc/nx-init-angular
branch
from
81e9b53
to
6ca8aa7
Compare
meeroslav
reviewed
Mar 6, 2023
meeroslav
approved these changes
Mar 6, 2023
leosvelperez
force-pushed
the
misc/nx-init-angular
branch
from
6ca8aa7
to
bb30370
Compare
…ed angular version
leosvelperez
force-pushed
the
misc/nx-init-angular
branch
from
3d053f4
to
ea42de0
Compare
FrozenPandaz
approved these changes
Mar 7, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
nx initcommand doesn't contain the implementation for migrating Angular CLI workspaces. Instead, it defers that to a separate package (make-angular-cli-faster) created for a different purpose.Expected Behavior
The
nx initcommand contains the implementation for migrating Angular CLI workspaces.Note: the
make-angular-cli-fasterpackage will be removed in a separate PR once this one lands.Related Issue(s)
Fixes #