Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): misc daemon fixes #15472

Merged
merged 21 commits into from
Mar 20, 2023
Merged

fix(core): misc daemon fixes #15472

merged 21 commits into from
Mar 20, 2023

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Mar 6, 2023

Current Behavior

  • Daemon does not stop while doing migrations
  • DaemonClient reset does not close the socket connection
  • DaemonClient out and err file handlers are not closed
  • The socket path was created with the workspace root, but didnt take case sensitivity into account, (ie. On Windows, Nx Console will send c:\workspace\path, but the daemon will have C:\workspace\path) causing multiple daemons to always respawn

Expected Behavior

  • The Daemon will now be reset when doing migrations
  • DaemonClient will reset at the appropriate time
  • The file handles for the out and err writes are closed by the client (but still kept for the daemon process)
  • Daemon socket path is now case insensitive

Related Issue(s)

Fixes #15424
Fixes #15480

@vercel
Copy link

vercel bot commented Mar 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 8:50PM (UTC)

packages/nx/src/command-line/migrate.ts Outdated Show resolved Hide resolved
@Cammisuli Cammisuli changed the title fix(core): stop the daemon before doing migrations fix(core): stop the daemon during migrations and disconnect the client Mar 6, 2023
packages/nx/src/daemon/client/client.ts Outdated Show resolved Hide resolved
packages/nx/src/daemon/client/client.ts Outdated Show resolved Hide resolved
packages/nx/src/hasher/file-hasher.ts Outdated Show resolved Hide resolved
@Cammisuli Cammisuli changed the title fix(core): stop the daemon during migrations and disconnect the client fix(core): misc daemon fixes Mar 15, 2023
packages/nx/src/command-line/migrate.ts Outdated Show resolved Hide resolved
packages/nx/src/daemon/server/shutdown-utils.ts Outdated Show resolved Hide resolved
@Cammisuli Cammisuli merged commit 84075c3 into nrwl:master Mar 20, 2023
@Cammisuli Cammisuli deleted the native_fixes branch March 20, 2023 01:10
FrozenPandaz pushed a commit that referenced this pull request Mar 22, 2023
FrozenPandaz pushed a commit that referenced this pull request Mar 23, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createProjectGraphAsync() causes process to not complete Unable to update nx on windows with native code
3 participants