New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): refactor the logging logic in e2e tests #15548

Merged

mandarini merged 1 commit into nrwl:master from mandarini:chore/e2e-logs-refactor

Mar 9, 2023

Member

mandarini commented Mar 8, 2023 •

edited

Loading

change ['pipe', 'pipe', 'pipe'] to pipe
enhance the way isVerbose() is used
change look of output if isVerbose()
make sure error is always caught and logged
remove unnecessary .toString() since we're using encoding to all execSync commands
add optional chaining where needed

Comments

Output, if error, is always displayed.

The thing is, however, that in the test summary, if there was an error, still the stack trace of error on execSync is displayed. We can take a look at whether this is configurable or not at a later PR.

vercel bot commented Mar 8, 2023 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
nx-dev	⬜️ Ignored (Inspect)			Mar 9, 2023 at 4:07PM (UTC)

nx-cloud bot commented Mar 8, 2023 •

edited

Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5ecd7d1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

mandarini force-pushed the chore/e2e-logs-refactor branch from f510a6f to c295022 Compare

March 8, 2023 20:26

mandarini changed the title ~~Chore/e2e logs refactor~~ fix(core): refactor the logging logic in e2e tests

mandarini marked this pull request as ready for review

March 8, 2023 20:27

mandarini requested review from meeroslav, barbados-clemens, vsavkin, FrozenPandaz, AgentEnder, leosvelperez and Coly010 as code owners

March 8, 2023 20:27

mandarini self-assigned this

mandarini force-pushed the chore/e2e-logs-refactor branch from c295022 to f10d285 Compare

March 8, 2023 20:40

leosvelperez approved these changes

View reviewed changes

Coly010 approved these changes

View reviewed changes

mandarini enabled auto-merge (squash)

March 9, 2023 09:36

meeroslav reviewed

View reviewed changes

e2e/utils/command-utils.ts Outdated Show resolved Hide resolved

meeroslav reviewed

View reviewed changes

e2e/utils/command-utils.ts Show resolved Hide resolved

meeroslav reviewed

View reviewed changes

e2e/utils/command-utils.ts Outdated Show resolved Hide resolved

meeroslav reviewed

View reviewed changes

e2e/utils/command-utils.ts Outdated Show resolved Hide resolved

meeroslav reviewed

View reviewed changes

e2e/utils/command-utils.ts Outdated Show resolved Hide resolved

meeroslav reviewed

View reviewed changes

e2e/utils/command-utils.ts Outdated Show resolved Hide resolved

meeroslav reviewed

View reviewed changes

e2e/utils/command-utils.ts Outdated Show resolved Hide resolved

meeroslav reviewed

View reviewed changes

e2e/utils/create-project-utils.ts Outdated Show resolved Hide resolved

meeroslav reviewed

View reviewed changes

e2e/utils/create-project-utils.ts Outdated Show resolved Hide resolved

meeroslav reviewed

View reviewed changes

e2e/utils/create-project-utils.ts Outdated Show resolved Hide resolved

meeroslav reviewed

View reviewed changes

e2e/utils/get-env-info.ts Outdated Show resolved Hide resolved

meeroslav requested changes

View reviewed changes

Contributor

meeroslav left a comment

I have some minor changes.

mandarini force-pushed the chore/e2e-logs-refactor branch from f10d285 to af0b3d7 Compare

March 9, 2023 11:29

mandarini requested a review from meeroslav

March 9, 2023 14:44

barbados-clemens reviewed

View reviewed changes

Contributor

barbados-clemens left a comment

Thanks for this!
just a place to reuse the stripConsoleColor is the only thing I see in the PR.

e2e/utils/command-utils.ts Outdated Show resolved Hide resolved


          fix(core): refactor the logging logic in e2e tests

5ecd7d1

mandarini force-pushed the chore/e2e-logs-refactor branch from af0b3d7 to 5ecd7d1 Compare

March 9, 2023 16:06

mandarini requested a review from barbados-clemens

March 9, 2023 16:16

barbados-clemens approved these changes

View reviewed changes

meeroslav approved these changes

View reviewed changes

AgentEnder approved these changes

View reviewed changes

mandarini merged commit a0e00c8 into nrwl:master

mandarini mentioned this pull request

feat(repo): add new flag for verbose e2e logging #15541

Merged

nartc pushed a commit to nartc/nx that referenced this pull request


          fix(core): refactor the logging logic in e2e tests (nrwl#15548)

fe2ec92

FrozenPandaz pushed a commit that referenced this pull request


          fix(core): refactor the logging logic in e2e tests (#15548)

9c84e1d

(cherry picked from commit a0e00c8)

github-actions bot commented Mar 15, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

meeroslav meeroslav approved these changes

AgentEnder AgentEnder approved these changes

leosvelperez leosvelperez approved these changes

Coly010 Coly010 approved these changes

barbados-clemens barbados-clemens approved these changes

vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

FrozenPandaz Awaiting requested review from FrozenPandaz FrozenPandaz is a code owner