-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repo): add new flag for verbose e2e logging #15541
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mandarini is also refactoring the e2e utils to add the isVerbose() check in places to probably a merge conflict coming for one of y'all.
Yes, the two of us are in sync. |
My PR caused these merge conflicts, I can fix them tomorrow to keep the logic I intended. If @vsavkin @FrozenPandaz can take a look in the meantime and see if this can be approved, so we can merge tomorrow morning our time, after conflicts are fixed? |
b09d763
to
6adcc6f
Compare
I have rebased it @mandarini. We do need the review though. |
6adcc6f
to
785d945
Compare
861888a
to
3339c5a
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Existing NX_VERBOSE_LOGGING is too broad for E2E tests and creates a lot of noise in the output.
The new NX_E2E_VERBOSE_LOGGING reports just relevant logs.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #