Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): add new flag for verbose e2e logging #15541

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Mar 8, 2023

Existing NX_VERBOSE_LOGGING is too broad for E2E tests and creates a lot of noise in the output.
The new NX_E2E_VERBOSE_LOGGING reports just relevant logs.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Mar 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2023 at 5:10PM (UTC)

Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandarini is also refactoring the e2e utils to add the isVerbose() check in places to probably a merge conflict coming for one of y'all.

@meeroslav
Copy link
Contributor Author

@mandarini is also refactoring the e2e utils to add the isVerbose() check in places to probably a merge conflict coming for one of y'all.

Yes, the two of us are in sync.

@mandarini
Copy link
Member

mandarini commented Mar 9, 2023

My PR caused these merge conflicts, I can fix them tomorrow to keep the logic I intended. If @vsavkin @FrozenPandaz can take a look in the meantime and see if this can be approved, so we can merge tomorrow morning our time, after conflicts are fixed?

@meeroslav meeroslav force-pushed the add-new-verbose-flag-for-e2e branch from b09d763 to 6adcc6f Compare March 10, 2023 00:09
@meeroslav
Copy link
Contributor Author

I have rebased it @mandarini. We do need the review though.

e2e/utils/command-utils.ts Show resolved Hide resolved
e2e/utils/command-utils.ts Show resolved Hide resolved
e2e/utils/command-utils.ts Show resolved Hide resolved
@meeroslav meeroslav force-pushed the add-new-verbose-flag-for-e2e branch from 861888a to 3339c5a Compare March 13, 2023 17:10
@meeroslav meeroslav merged commit 7450e72 into nrwl:master Mar 13, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
@meeroslav meeroslav deleted the add-new-verbose-flag-for-e2e branch April 27, 2023 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants