-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): add rspack experimental support #16252
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments. Overall looks good!
61276bc
to
14eb569
Compare
14eb569
to
869c5a8
Compare
869c5a8
to
14065c7
Compare
14065c7
to
faa2829
Compare
should an e2e test for rspack to be added? |
Let's leave it off for now, there is something in the labs repo that tests similar setup on a nightly basis. |
faa2829
to
e2965c8
Compare
packages/react/src/generators/application/files/base-rspack/tsconfig.app.json__tmpl__
Outdated
Show resolved
Hide resolved
e2965c8
to
3078727
Compare
Squashed commit of the following: commit a51ac58 Author: Miroslav Jonaš <meeroslav@users.noreply.github.com> Date: Thu Apr 20 09:16:45 2023 +0200 fix(core): do not expect each package to have hoisted version in lockfile (nrwl#16393) commit 4a4fc19 Author: Miroslav Jonaš <meeroslav@users.noreply.github.com> Date: Thu Apr 20 09:16:32 2023 +0200 fix(core): enforce fixed versions only for apps with createPackageJson (nrwl#16398) commit 8400484 Author: Emily Xiong <xiongemi@gmail.com> Date: Wed Apr 19 20:36:11 2023 -0400 feat(core): update create-nx-plugin to generate cli library (nrwl#15994) commit 16e4061 Author: Craigory Coppola <craigorycoppola@gmail.com> Date: Wed Apr 19 18:25:41 2023 -0400 feat(devkit): bump support range to be 15 <= x <= 17 (nrwl#16421) commit fc07794 Author: Craigory Coppola <craigorycoppola@gmail.com> Date: Wed Apr 19 18:07:56 2023 -0400 feat(core): remove deprecated affected commands (nrwl#16349) commit a798576 Author: Craigory Coppola <craigorycoppola@gmail.com> Date: Wed Apr 19 17:02:34 2023 -0400 fix(misc): pass e2eTestRunner to child preset generator (nrwl#16414) commit 338dc64 Author: Nicholas Cunningham <ndcunningham@gmail.com> Date: Wed Apr 19 13:29:31 2023 -0600 feat(nextjs): Add standalone Nextjs option to react selection when running CNW (nrwl#16317) commit 16e115f Author: Emily Xiong <xiongemi@gmail.com> Date: Wed Apr 19 15:03:36 2023 -0400 fix(react-native): log errors for pod install (nrwl#16386) commit 0fc3d44 Author: FrozenPandaz <jasonjean1993@gmail.com> Date: Wed Apr 19 14:24:10 2023 -0400 chore(misc): publish 16.0.0-beta.4 commit f7ca6e6 Author: Craigory Coppola <craigorycoppola@gmail.com> Date: Wed Apr 19 14:21:30 2023 -0400 chore(misc): update migration version for workspace-generator (nrwl#16417) commit b3ca503 Author: Craigory Coppola <craigorycoppola@gmail.com> Date: Wed Apr 19 14:12:09 2023 -0400 fix(core): hide duplicate log entry when displaying generator help (nrwl#16353) commit 9fa6d41 Author: Craigory Coppola <craigorycoppola@gmail.com> Date: Wed Apr 19 14:06:57 2023 -0400 fix(misc): mark workspace-lint as deprecated in yargs config (nrwl#16385) commit 9c9abaa Author: Emily Xiong <xiongemi@gmail.com> Date: Wed Apr 19 14:03:45 2023 -0400 fix(react-native): remove listDevices default value for run-android (nrwl#16410) commit 1743ff1 Author: Craigory Coppola <craigorycoppola@gmail.com> Date: Wed Apr 19 14:03:00 2023 -0400 feat(core): add migration to update workspace generators to a local plugin (nrwl#12700) commit f04f316 Author: Jack Hsu <jack.hsu@gmail.com> Date: Wed Apr 19 14:00:24 2023 -0400 feat(react): add rspack experimental support (nrwl#16252) commit 1ff450b Author: Jason Jean <jasonjean1993@gmail.com> Date: Wed Apr 19 13:43:44 2023 -0400 fix(core): fix devkit compatibility (nrwl#16413) commit 6677a9c Author: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com> Date: Wed Apr 19 18:32:51 2023 +0100 feat(misc): expose nx init command flags (nrwl#16287) commit 5d7ad34 Author: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com> Date: Wed Apr 19 18:22:52 2023 +0100 feat(testing): bump ts-jest to 29.1.0 to support typescript 5.x (nrwl#16401) commit a8e85da Author: Dominik Pieper <dominik@pieper.io> Date: Wed Apr 19 19:01:50 2023 +0200 feat(testing): export cypressE2EConfigurationGenerator (nrwl#16394) commit 1ad7e3d Author: Caleb Ukle <caleb@nrwl.io> Date: Wed Apr 19 11:55:11 2023 -0500 fix(testing): nullcheck polyfills in ng component testing (nrwl#16411) commit c963393 Author: Katerina Skroumpelou <mandarini@users.noreply.github.com> Date: Wed Apr 19 19:34:38 2023 +0300 fix(storybook): dont use swc addon on sb7 and format (nrwl#16408) commit c8960b7 Author: Miroslav Jonaš <meeroslav@users.noreply.github.com> Date: Wed Apr 19 17:13:10 2023 +0200 fix(linter): don't confuse buildable libs for secondary ng entry point (nrwl#16367) commit 2734401 Author: FrozenPandaz <jasonjean1993@gmail.com> Date: Wed Apr 19 11:10:19 2023 -0400 chore(misc): publish 16.0.0-beta.3 commit da158bc Author: Jason Jean <jasonjean1993@gmail.com> Date: Wed Apr 19 10:59:58 2023 -0400 feat(angular): replace usages of @nrwl with @nx (nrwl#16377) Co-authored-by: Colum Ferry <cferry09@gmail.com> commit 76dfc62 Author: Jason Jean <jasonjean1993@gmail.com> Date: Wed Apr 19 10:59:41 2023 -0400 feat(web): replace usages of @nrwl with @nx (nrwl#16376) commit 1780aac Author: Jack Hsu <jack.hsu@gmail.com> Date: Wed Apr 19 10:57:34 2023 -0400 feat(react): add @nx/web as a dependency since it is needed by cypress/etc. (nrwl#16407) commit 52acf07 Author: Jason Jean <jasonjean1993@gmail.com> Date: Wed Apr 19 10:40:37 2023 -0400 fix(angular): fix resolve builder in ngcli adapter (nrwl#16375) commit ab609a2 Author: Jack Hsu <jack.hsu@gmail.com> Date: Wed Apr 19 10:38:01 2023 -0400 fix(js): update swc options so path mappings can work in all environments (nrwl#16390) commit 157b35b Author: Katerina Skroumpelou <mandarini@users.noreply.github.com> Date: Wed Apr 19 17:33:10 2023 +0300 fix(storybook): do not override existing v7 on init (nrwl#16405)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR adds the Rspack bundler as an option when generating a new React standalone workspace, and new React apps.
When prompting for
bundler
, user can choose between Vite, Webpack, or Rspack.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #