Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add ngrx feature store generator #16806

Merged
merged 1 commit into from
May 9, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 5, 2023

Current Behavior

We have one NgRx Generator that currently tries to handle two different use cases and as such has come conflicting logic and a lot of branching to determine which use case to run.

Expected Behavior

We should have two separate generators that focus purely on each use case:

  1. Add NgRx Root Setup to an application
  2. Add an NgRx Feature Store to an application or library

This PR addresses 2.

There are cases when there should also be a root state, so the root state generator can then invoke this generator for that case.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 0:56am

Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on the generated docs changes

@Coly010 Coly010 merged commit 54eb7be into nrwl:master May 9, 2023
@Coly010 Coly010 deleted the angular/ngrx-root-generator branch May 9, 2023 08:31
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants