-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js): node executor now correctly kills tasks when exiting #19219
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
I've been looking for this as well! |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e4678eb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Previously, the node executor od @nx/js did not kill spawned processes due to not awaiting finishing of killing and infinite loop. This fix allows for seemless running nx in docker containers with support for signals
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Previously, the node executor od @nx/js did not kill spawned processes due to not awaiting finishing of killing and infinite loop.
This fix allows for seemless running nx in docker containers with support for signals
Current Behavior
When killing nx running
@nx/js:node
, child processes are not killedExpected Behavior
Child processes should be killed