Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): node executor now correctly kills tasks when exiting #26355

Closed
wants to merge 1 commit into from

Conversation

ndcunningham
Copy link
Contributor

Previously, the node executor od @nx/js did not kill spawned processes due to not awaiting finishing of killing and infinite loop.
This fix allows for seemless running nx in docker containers with support for signals

Taken from: #19219

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 4:42pm

@ndcunningham ndcunningham marked this pull request as ready for review June 4, 2024 16:39
@ndcunningham ndcunningham requested a review from a team as a code owner June 4, 2024 16:39
Previously, the node executor od @nx/js did not kill spawned processes due to not awaiting finishing
of killing and infinite loop.
This fix allows for seemless running nx in docker containers with support for signals
@ndcunningham ndcunningham deleted the fix/nodejs-end-process branch June 4, 2024 17:25
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants