fix(release): do not restart the daemon when skipLockFileUpdate is set #21389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ac05089. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
fahslaj
force-pushed
the
fix/skip-lock-file-update
branch
from
7dc29d1
to
eb427c7
Compare
fahslaj
requested review from
a team,
FrozenPandaz,
vsavkin,
AgentEnder,
jaysoo and
JamesHenry
as code owners
FrozenPandaz
approved these changes
Jan 29, 2024
JamesHenry
approved these changes
Jan 29, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The daemon is always restarted after
nx release version. Verbose logging is not propagated down to the nx release subcommands in thenx-releasescript.Expected Behavior
The daemon is not restarted after
nx release versionifskipLockFileUpdateis set. Verbose logging is propagated down to the subcommands in thenx-releasescript.