Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-cloud): update gh onboarding url #26587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Jun 18, 2024

Features

  • update GitHub onboarding URL

  • Do not generate token on nx-connect if user uses GitHub and do not change their nx.json

  • open browser to connect to Nx Cloud automatically when user is on nx connect and uses GitHub

  • Create separate commit for Nx cloud token and CI on create-nx-workspace

  • Fix the messaging for create-nx-workspace

  • Updated git commit and fixed body lines when printing connect URL

  • check Nx Cloud version - if less than 2406.11.5 then just print a URL to the root of the site

Wed 19 Jun updates

  • Add URL to nx connect message for opening browser
Screenshot 2024-06-19 at 4 34 26 PM
  • Include "connect to cloud" URL in the create-nx-workspace commit message
Screenshot 2024-06-19 at 4 26 31 PM
  • change stop to succeed for ora spinner

Videos

I have created two looms for this, they are attached to the Linear issues related to this PR.

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 21, 2024 0:10am

@mandarini mandarini self-assigned this Jun 18, 2024
@mandarini mandarini requested a review from jdpearce June 18, 2024 10:34
@mandarini mandarini force-pushed the feat/cli-onboard-updates branch 3 times, most recently from 210c9ef to 848b0be Compare June 18, 2024 14:38
@mandarini mandarini added the PR status: do not merge This will block a PR from being merged until this tag is removed. label Jun 18, 2024
@mandarini mandarini marked this pull request as ready for review June 18, 2024 14:53
Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-26587-848b0be my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-26587-848b0be
Release details 📑
Published version 0.0.0-pr-26587-848b0be
Triggered by @mandarini
Branch feat/cli-onboard-updates
Commit 848b0be
Workflow run 9567431433

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Copy link

Failed to publish a PR release of this pull request, triggered by @mandarini.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/9583025148

Copy link

Failed to publish a PR release of this pull request, triggered by @mandarini.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/9583355438

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-26587-1fa73c5 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-26587-1fa73c5
Release details 📑
Published version 0.0.0-pr-26587-1fa73c5
Triggered by @mandarini
Branch feat/cli-onboard-updates
Commit 1fa73c5
Workflow run 9592698274

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@mandarini mandarini force-pushed the feat/cli-onboard-updates branch 2 times, most recently from be89b03 to 3f2f1ad Compare June 21, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR status: do not merge This will block a PR from being merged until this tag is removed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant