Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): custom typescript webpack config files are now compatible #7627

Closed
wants to merge 5 commits into from
Closed

fix(web): custom typescript webpack config files are now compatible #7627

wants to merge 5 commits into from

Conversation

ndcunningham
Copy link
Contributor

Current Behavior

Currently, when a custom typescript webpack configuration file is passed in as an option for the build executor (react applications) nx run project:serve fails

Expected Behavior

Nx should support custom typescript webpack configs for react applications

Related Issue(s)

Fixes #7454

@vercel
Copy link

vercel bot commented Nov 5, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/9M4bjnPtLhHujEqjLrkRhLaW9EAd
✅ Preview: https://nx-dev-git-fork-ndcunningham-fix-custom-typescript-6c6739-nrwl.vercel.app

@ndcunningham ndcunningham changed the title Fix custom typescript webpack import for React fix(web): custom typescript webpack config files are now compatible Nov 5, 2021
@nx-cloud
Copy link

nx-cloud bot commented Nov 5, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 093073e. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --base=7332bbce81e0665f2bcc905f0aad71b48827e8a7 --head=093073e72c3992ec7b6a4944f576ac20752341da --parallel --max-parallel=3
#000000 nx affected --target=e2e --base=7332bbce81e0665f2bcc905f0aad71b48827e8a7 --head=093073e72c3992ec7b6a4944f576ac20752341da --exclude=e2e-next,e2e-gatsby,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-storybook,e2e-cypress,e2e-node,e2e-linter,e2e-je...
#000000 nx affected --target=lint --base=7332bbce81e0665f2bcc905f0aad71b48827e8a7 --head=093073e72c3992ec7b6a4944f576ac20752341da --parallel --max-parallel=4
#000000 nx affected --target=test --base=7332bbce81e0665f2bcc905f0aad71b48827e8a7 --head=093073e72c3992ec7b6a4944f576ac20752341da --parallel --max-parallel=2
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

@ndcunningham
fix(web): custom typescript webpack config files are now compatible f…
454d107 
…or react applications

When a typescript webpack config file is provided as an option for the web build executor `nx run
project:serve` will not fail because the file type is typescript.

ISSUES CLOSED: nrwl#7454
@ndcunningham ndcunningham force-pushed the fix-custom-typescript-webpack-import branch from 179d56b to 454d107 Compare November 5, 2021 20:23
@ndcunningham
Copy link
Contributor Author

Closing in favour of: #7633

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaysoo jaysoo jaysoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use TypeScript webpack config
2 participants
@ndcunningham @jaysoo