Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lxml to install_requires in setup.py #69

Closed
bonh opened this issue Mar 2, 2017 · 2 comments
Closed

Add lxml to install_requires in setup.py #69

bonh opened this issue Mar 2, 2017 · 2 comments

Comments

@bonh
Copy link

bonh commented Mar 2, 2017

If converting from gmsh to dolfin-xml works without a running installation of dolfin, the required package lxml should be added to install_requires in setup.py.
@nschloe
Copy link
Owner

nschloe commented Mar 2, 2017

Not sure about this one. After all, lxml is an optional dependency that's necessary only if you want to convert from/to Dolfin XML. The keyword extras_require is probably what we're looking for here.

@nschloe
Copy link
Owner

nschloe commented Mar 14, 2017

lxml is now in extras_require.

@nschloe nschloe closed this as completed Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nschloe @bonh