-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement simpler API signatures #167
Comments
I like this approach. However, this methods requires knowing the concept id or short name first. This is fine if you know your dataset or know to go to EarthData Search but we need to explain that step. Otherwise getting the shortname is "magic". |
I totally agree @andypbarrett, we need to explain where this |
I was wondering if the current search keyword arguments are based on the earthdata search API? Perhaps it'd be possible to use STAC-API standards for more consistency across libraries (at least for the main spatiotemporal ones?). I know it's nitpicky and annoying to have breaking changes like this, but the user experience is nice coming from other libraries like pystac_client / nasa-cmr-stac. and perhaps the standard names and acceptable formats could have the benefit of re-using already implemented parsers in those other libraries. https://github.com/radiantearth/stac-api-spec/tree/main/item-search#query-parameter-table
|
This is a great idea @scottyhq !! they don't have to be breaking changes, we can just add them as aliases to the class methods and will work the same way (without breaking the old names), the only thing that might need some work is processing the GeoGSON geometry for |
Closing after 10 days of waiting for feedback. If you feel this was in error, please re-open, |
@betolink Is this still relevant with more recent earthaccess releases? What does this proposal achieve compared to what we currently support? |
The concept of collections vs granules and instantiating those classes can be confusing, especially for new users. Perhaps having a static method that can simplify things would be simpler to use e.g. (using the upcoming name)
This would be better suited for regional use cases since we'll be downloading the metadata from CMR in one go.
Workflows that may require bulk downloads could potentially use an iterator like
The text was updated successfully, but these errors were encountered: