Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend netmode package with NeoFSMainNet and NeoFSTestNet #3503

Closed
AnnaShaleva opened this issue Jul 5, 2024 · 3 comments · Fixed by #3539
Closed

Extend netmode package with NeoFSMainNet and NeoFSTestNet #3503

AnnaShaleva opened this issue Jul 5, 2024 · 3 comments · Fixed by #3539
Assignees
Labels
discussion Open discussion of some problem enhancement Improving existing functionality I2 Regular impact S4 Routine U4 Nothing urgent
Milestone

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

netmode package doesn't contain NeoFS chains IDs. We've already discussed this problem with @roman-khimov, but I can't find the conversation. The arguments against extension were that NeoFS-related things are not finally established in the Neo ecosystem as it required for moving these constants to the netmode package.

But I see that there are users of NeoGo for those it will be useful to have a designated constants for NeoFS networks, because they work with NeoFS node configs. Thus, I suggest to consider extending netmode package one more time.

Describe the solution you'd like

Add netmode.NeoFSMainNet and netmode.NeoFSTestNet constants.

Describe alternatives you've considered

Keep netmode package as is and let the users of netmode package handle FS chain configs by their own forces.

@AnnaShaleva AnnaShaleva added discussion Open discussion of some problem I2 Regular impact U4 Nothing urgent enhancement Improving existing functionality S4 Routine labels Jul 5, 2024
@AnnaShaleva AnnaShaleva added this to the v0.106.3 milestone Jul 5, 2024
@AnnaShaleva
Copy link
Member Author

BTW, it should likely be netmode.MainNetNeoFS and netmode.TestNetNeoFS to match the embeds:

// MainNetNeoFS is the mainnet NeoFS configuration.
//
//go:embed protocol.mainnet.neofs.yml
var MainNetNeoFS []byte
// TestNetNeoFS is the testnet NeoFS configuration.
//
//go:embed protocol.testnet.neofs.yml
var TestNetNeoFS []byte

@roman-khimov
Copy link
Member

Mainnet and testnet networks are well-known, can be added.

@roman-khimov roman-khimov modified the milestones: v0.106.3, v0.106.4 Jul 26, 2024
@ixje
Copy link
Contributor

ixje commented Jul 30, 2024

😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Open discussion of some problem enhancement Improving existing functionality I2 Regular impact S4 Routine U4 Nothing urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants