Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ObjectReader/ObjectRangeReader compatible with io.Closer/io.ReaderCloser #405

Closed
roman-khimov opened this issue Apr 29, 2023 · 1 comment · Fixed by #413
Closed
Assignees
Labels
enhancement Improving existing functionality
Milestone

Comments

@roman-khimov
Copy link
Member

Consider nspcc-dev/neo-go#2995, there is an oracle subsystem that can do requests via HTTP and via NeoFS protocol. In the successful case we get some io.ReaderCloser for HTTP, but we have some really strange thing for NeoFS, it's io.Reader, but it's not io.ReaderCloser because its Close method returns some alien things. This means we can't unify some of the code for these cases even though they look very similar. Implementing proper io.Closer would be make for a much better library interface.

@roman-khimov roman-khimov added enhancement Improving existing functionality discussion Open discussion of some problem labels Apr 29, 2023
@cthulhu-rider
Copy link
Contributor

can be done similar to #382 (comment)

@roman-khimov roman-khimov added this to the v1.0.0-rc9 milestone May 18, 2023
@roman-khimov roman-khimov removed the discussion Open discussion of some problem label May 18, 2023
roman-khimov added a commit that referenced this issue May 19, 2023
@smallhive smallhive self-assigned this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants