Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate neotest with local RPC client #3245

Open
AnnaShaleva opened this issue Dec 1, 2023 · 2 comments
Open

Integrate neotest with local RPC client #3245

AnnaShaleva opened this issue Dec 1, 2023 · 2 comments
Labels
enhancement Improving existing functionality I2 Regular impact rpc RPC server and client S2 Regular significance test Unit tests U3 Regular
Milestone
v0.108.0

Comments

@AnnaShaleva
Copy link
Member

Implement the #3233 (comment).
@AnnaShaleva AnnaShaleva added rpc RPC server and client test Unit tests enhancement Improving existing functionality labels Dec 1, 2023
@AnnaShaleva AnnaShaleva added this to the v0.106.0 milestone Dec 1, 2023
fyfyrchik added a commit to fyfyrchik/neo-go that referenced this issue Dec 8, 2023
@fyfyrchik
neotest: reuse wallet.Account for contract signers
02b9c49 
Refs nspcc-dev#3245

Signed-off-by: Evgenii Stratonikov <fyfyrchik@runbox.com>
fyfyrchik added a commit to fyfyrchik/neo-go that referenced this issue Dec 8, 2023
@fyfyrchik
neotest: reuse wallet.Account for contract signers
897b1d9 
Refs nspcc-dev#3245

Signed-off-by: Evgenii Stratonikov <fyfyrchik@runbox.com>
fyfyrchik added a commit to fyfyrchik/neo-go that referenced this issue Dec 8, 2023
@fyfyrchik
neotest: reuse wallet.Account for contract signers
ea8ac08 
Refs nspcc-dev#3245

Signed-off-by: Evgenii Stratonikov <fyfyrchik@runbox.com>
fyfyrchik added a commit to fyfyrchik/neo-go that referenced this issue Dec 8, 2023
@fyfyrchik
neotest: reuse wallet.Account for contract signers
f0e8381 
Refs nspcc-dev#3245
Refs nspcc-dev#3233

Signed-off-by: Evgenii Stratonikov <fyfyrchik@runbox.com>
fyfyrchik added a commit to fyfyrchik/neo-go that referenced this issue Dec 8, 2023
@fyfyrchik
neotest: reuse wallet.Account for contract signers
2076fda 
Refs nspcc-dev#3245
Refs nspcc-dev#3233

Signed-off-by: Evgenii Stratonikov <fyfyrchik@runbox.com>
fyfyrchik added a commit to fyfyrchik/neo-go that referenced this issue Dec 21, 2023
@fyfyrchik
neotest: reuse wallet.Account for contract signers
c8ff445 
Refs nspcc-dev#3245
Refs nspcc-dev#3233

Signed-off-by: Evgenii Stratonikov <fyfyrchik@runbox.com>
@roman-khimov roman-khimov added I2 Regular impact U3 Regular S2 Regular significance labels Dec 21, 2023
@AnnaShaleva AnnaShaleva modified the milestones: v0.106.0, v0.107.0 Jan 19, 2024
@AnnaShaleva AnnaShaleva mentioned this issue Apr 28, 2024
Merged
@AnnaShaleva
Copy link
Member Author

We also need to refactor all tests where some custom network fee is added for transaction witnesses. Ref. #3425 (comment).

@AnnaShaleva AnnaShaleva mentioned this issue Aug 9, 2024
Merged
@AnnaShaleva
Copy link
Member Author

Also need to adjust neotest.AddSystemFee (or (*Executor).AddSystemFee) to properly handle RPC GAS limit problem that may happen during system fee calculation. Ref. #3551 (comment).

@roman-khimov roman-khimov mentioned this issue Sep 23, 2024
Merged
@cthulhu-rider cthulhu-rider mentioned this issue Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I2 Regular impact rpc RPC server and client S2 Regular significance test Unit tests U3 Regular
Projects
None yet
Milestone
v0.108.0
Development

No branches or pull requests
2 participants
@roman-khimov @AnnaShaleva