Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC could not delete object that is split #1699

Closed
carpawell opened this issue Aug 17, 2022 · 3 comments
Closed

GC could not delete object that is split #1699

carpawell opened this issue Aug 17, 2022 · 3 comments
Assignees
Labels
bug Something isn't working neofs-storage Storage node application issues U3 Regular
Milestone

Comments

@carpawell
Copy link
Member

carpawell commented Aug 17, 2022

Our mainnet node asuka reported such logs:

asuka neofs-node[71361]: 2022-08-17T16:10:04.625Z        warn        shard/gc.go:216        could not delete the objects        {"error": "object not found, split info has been provided"}

It seems like GC must not get such errors while removing objects.

  1. Add object address to the error;
  2. Do not stop removing objects after fall (one of the shard kept many objects with GC and could do nothing with that);
  3. Recheck that removing split objects works correctly.

NeoFS version: v0.28.1

@carpawell carpawell added bug Something isn't working neofs-storage Storage node application issues labels Aug 17, 2022
@carpawell
Copy link
Member Author

Reproduced on master. Split objects could not be deleted.

@fyrchik
Copy link
Contributor

fyrchik commented Oct 6, 2022

  1. Consider indexing tomstone split id in metabase
  2. Consider handling specific errors in GC

@carpawell
Copy link
Member Author

Closed via #2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working neofs-storage Storage node application issues U3 Regular
Projects
None yet
Development

No branches or pull requests

3 participants