Consider -g flag usage in neofs-cli

[vkarak1]

Please leave '-g' flag usage where it makes sense. Please find below some examples where -g flag exists in command helper but can't / shouldn't be used:

root@az:/home/service# neofs-cli control shards list -g -r node1:8080
Error: unknown shorthand flag: 'r' in -r
Usage:
  neofs-cli control shards list [flags]

Flags:
      --address string     Address of wallet account
      --endpoint string    Remote node control address (as 'multiaddr' or '<host>:<port>')
  -g, --generate-key       Generate new private key
  -h, --help               help for list
      --json               Print shard info as a JSON array
  -t, --timeout duration   Timeout for an operation (default 15s)
  -w, --wallet string      Path to the wallet or binary key

Global Flags:
  -c, --config string   Config file (default is $HOME/.config/neofs-cli/config.yaml)
  -v, --verbose         Verbose output

unknown shorthand flag: 'r' in -r

It's allowed to create container with -g flag but you will not be able to delete it:

root@az:/home/service# neofs-cli container create --name rep1 --policy "REP 2 IN X CBF 1 SELECT 2 FROM * AS X" --basic-acl public-read-write -g --rpc-endpoint node1.neofs:8080   --await
container ID: mm73yxDPYoWNkKXc3pMjFn1CoZh2Gw93WfGjt9XYSnM
awaiting...
container has been persisted on sidechain
root@az:/home/service# neofs-cli container delete --cid mm73yxDPYoWNkKXc3pMjFn1CoZh2Gw93WfGjt9XYSnM  -r node1:8080
can't fetch private key: unable to read file from given path: open : no such file or directory
root@az:/home/service# neofs-cli container delete --cid mm73yxDPYoWNkKXc3pMjFn1CoZh2Gw93WfGjt9XYSnM  -r node1:8080 -f
can't fetch private key: unable to read file from given path: open : no such file or directory

Help for neofs-cli control drop-objects should be also updated, it looks like -g flag is not applicable here:

root@az:/home/service# neofs-cli object put   -g  -r node1:8080  --cid 9RP8Wtjpe2sj4KAvmUBrbjE1xU1NwFDZJiiwQ11Vkk4Z --file /etc/neofs/storage/tatlin-object-sber-tfstate/vkarakozov/object1 -t 100m
 157286400 / 157286400 [====================================================================================================================================================================================] 100.00% 1m41s
[/etc/neofs/storage/tatlin-object-sber-tfstate/vkarakozov/object1] Object successfully stored
  OID: 9BtkimwNZUY8U1xeAp1i9YmEE8TW4y2wSXxcBasjPWtu
  CID: 9RP8Wtjpe2sj4KAvmUBrbjE1xU1NwFDZJiiwQ11Vkk4Z
root@az:/home/service# neofs-cli control drop-objects -o 9RP8Wtjpe2sj4KAvmUBrbjE1xU1NwFDZJiiwQ11Vkk4Z/9BtkimwNZUY8U1xeAp1i9YmEE8TW4y2wSXxcBasjPWtu -g --endpoint localhost:8091
can't fetch private key: unable to read file from given path: open : no such file or directory

Your Environment

NeoFS Storage node
Version: v0.34.0-60-g02049ca5
GoVersion: go1.19.3

[vkarak1]

Also look at behavior of the neofs-cli control healthcheck parameter:

root@az:/home/service# neofs-cli control healthcheck -h
Health check of the NeoFS node. Checks storage node by default, use --ir flag to work with Inner Ring.

Usage:
  neofs-cli control healthcheck [flags]

Flags:
      --address string     Address of wallet account
      --endpoint string    Remote node control address (as 'multiaddr' or '<host>:<port>')
  -g, --generate-key       Generate new private key
  -h, --help               help for healthcheck
      --ir                 Communicate with IR node
  -t, --timeout duration   Timeout for an operation (default 15s)
  -w, --wallet string      Path to the wallet or binary key

Global Flags:
  -c, --config string   Config file (default is $HOME/.config/neofs-cli/config.yaml)
  -v, --verbose         Verbose output
root@az:/home/service# neofs-cli control healthcheck -g --endpoint localhost:8091
can't fetch private key: unable to read file from given path: open : no such file or directory
root@az:/home/service# neofs-cli control healthcheck -g --endpoint localhost:8091 --ir
can't fetch private key: unable to read file from given path: open : no such file or directory

[fyrchik]

Let's remove it from wherever is makes no sense.