Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoFS CLI: add node version to neofs-cli netmap nodeinfo output #700

Closed
anatoly-bogatyrev opened this issue Jun 7, 2021 · 5 comments · Fixed by #744
Closed

NeoFS CLI: add node version to neofs-cli netmap nodeinfo output #700

anatoly-bogatyrev opened this issue Jun 7, 2021 · 5 comments · Fixed by #744
Assignees
Milestone

Comments

@anatoly-bogatyrev
Copy link

It would be good to add node version to neofs-cli netmap nodeinfo output.
Thanks.

@alexvanin
Copy link
Contributor

alexvanin commented Jun 9, 2021

  1. NodeInfo is an API structure, thus it makes sense to pass API version there. However we can add explicit UserAgent string field.
  2. We can pass UserAgent as an X-Header in ResponseMetaHeader of each response.
  3. We can return UserAgent in Control API healthcheck, however it is going to be accessible only for allowed clients.

I don't mind (1) or (2).

(1) looks a bit wired because UserAgent field doesn't provide anything meaningful for API and it completely depends on implementation.

(2) requires to have this X-Header in all responses, which is also can be a bit too much.

Thoughts?

@alexvanin
Copy link
Contributor

alexvanin commented Jun 10, 2021

  1. We can set UserAgent attribute in NodeInfo.

@alexvanin
Copy link
Contributor

alexvanin commented Jun 15, 2021

  • Add UserAgent attributes to nodes in neofs-dev-env, e.g. NeoFSNode/0.21.1 or something like that.

@alexvanin
Copy link
Contributor

alexvanin commented Jul 13, 2021

We can't use / symbol in neofs-node attributes because it used to connect chain of attributes, e.g. Location:Europe/Country:Sweden, etc.
Can we use something like User-Agent:NeoFS-Node-v0.22.3? I know it is not user-agent everyone familiar with, but it's better than nothing.

/cc @realloc @anatoly-bogatyrev

@realloc
Copy link

realloc commented Jul 14, 2021

We have just two "special" characters: : and / in attributes definitions. Let's try support escaping them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants