New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add administation module for subnetworks #979

Closed

4 tasks

cthulhu-rider opened this issue Nov 17, 2021 · 1 comment · Fixed by #992

Closed

4 tasks

Add administation module for subnetworks #979

cthulhu-rider opened this issue Nov 17, 2021 · 1 comment · Fixed by #992

Assignees

Labels

enhancement neofs-adm

Milestone

Contributor

cthulhu-rider commented Nov 17, 2021 •

edited

Loading

Blocked by Add subnetwork contract neofs-contract#122

Summary

Subnet contract of NeoFS sidechain provides the functionality to create, manage and remove NeoFS subnetworks. We need to provide convenient functionality which allows to do it from admin utility.

Task

Add subnet module (cobra.Command).
Add create sub-command which creates new subnetwork using a private key. ID is generated randomly. It'd nice to provide same await approach as neofs-cli container create.
Add remove sub-command which removes subnetwork by ID using a private key. It'd nice to provide same await approach as neofs-cli container delete.
Provide access to methods for managing lists of keys (clients and nodes) with commands of the same name. Add/remove takes a list of keys. To manage client keys group ID should be provided or generated randomly.

The text was updated successfully, but these errors were encountered:

cthulhu-rider added enhancement neofs-adm labels

cthulhu-rider added this to the v0.27.0 milestone

cthulhu-rider mentioned this issue

NeoFS Subnetworks #775

Closed

Contributor

alexvanin commented Nov 25, 2021

Besides control of subnet contract, neofs-adm utility should deploy this contract at init and update stage for this release.

cthulhu-rider self-assigned this

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Deploy and update Subnet contract

974565a

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Add commands to create and remove subnets

9566a4a

Add `subnet` command which contains all subnet-related commands. Add
`create` sub-command for subnet creation. Add `remove` sub-command for
subnet removal.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider mentioned this issue

ADM: Add subnet-related commands #992

Merged

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Deploy and update Subnet contract

ecccae0

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Add commands to create and remove subnets

7c2343d

Add `subnet` command which contains all subnet-related commands. Add
`create` sub-command for subnet creation. Add `remove` sub-command for
subnet removal.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Deploy missing contracts during updating

e4dbd80

Make `nnsResolveHash` function to return declared error if NNS record is
missing. Catch this error in `deployContracts` method, and switch to
deployment if updating contract is missing.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Deploy missing contracts during updating

eea84ac

Make `nnsResolveHash` function to return declared error on `token not
found` fault exception. Catch this error in `deployContracts` method,
and switch to deployment if updating contract is missing.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Register NNS domain for of the deployed contracts

071513d

Make `deployContracts` method to call `nnsRegisterDomain` in order to
register NNS domain for deployed contracts.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Register NNS domain for of the deployed contracts

6f3a8ec

Make `deployContracts` method to call `nnsRegisterDomain` in order to
register NNS domain for deployed contracts.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Register NNS domain for of the deployed contracts

c91ed96

Make `deployContracts` method to call `nnsRegisterDomain` in order to
register NNS domain for deployed contracts.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Register NNS domain for of the deployed contracts

f0fd05f

Make `deployContracts` method to call `nnsRegisterDomain` in order to
register NNS domain for deployed contracts.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Register NNS domain of the deployed contracts

739c1aa

Make `deployContracts` method to call `nnsRegisterDomain` in order to
register NNS domain for deployed contracts.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Add subnet-related commands

218fa55

Add `subnet` command which contains all subnet-related commands. Add
sub-commands:
  * `create` for creation;
  * `remove` for removal;
  * `get` for reading;
  * `admin` for admin management;
  * `client` for client management.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Deploy missing contracts during updating

32bbcb9

Make `nnsResolveHash` function to return declared error on `token not
found` fault exception. Catch this error in `deployContracts` method,
and switch to deployment if updating contract is missing.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Register NNS domain of the deployed contracts

9945b16

Make `deployContracts` method to call `nnsRegisterDomain` in order to
register NNS domain for deployed contracts.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Add subnet-related commands

fd5731b

Add `subnet` command which contains all subnet-related commands. Add
sub-commands:
  * `create` for creation;
  * `remove` for removal;
  * `get` for reading;
  * `admin` for admin management;
  * `client` for client management.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Deploy missing contracts during updating

332bd7e

Make `nnsResolveHash` function to return declared error on `token not
found` fault exception. Catch this error in `deployContracts` method,
and switch to deployment if updating contract is missing.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Register NNS domain of the deployed contracts

d49d5ba

Make `deployContracts` method to call `nnsRegisterDomain` in order to
register NNS domain for deployed contracts.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Add subnet-related commands

c222392

Add `subnet` command which contains all subnet-related commands. Add
sub-commands:
  * `create` for creation;
  * `remove` for removal;
  * `get` for reading;
  * `admin` for admin management;
  * `client` for client management.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Deploy missing contracts during updating

deaff30

Make `nnsResolveHash` function to return declared error on `token not
found` fault exception. Catch this error in `deployContracts` method,
and switch to deployment if updating contract is missing.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Register NNS domain of the deployed contracts

4c90ee0

Make `deployContracts` method to call `nnsRegisterDomain` in order to
register NNS domain for deployed contracts.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] morph/client: Get proxy contract address from NNS

8ede573

Make `Client.EnableNotarySupport` method to call `NNSContractAddress`
for proxy contract if it is not specified in corresponding option.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Fix problems after testing

Use persistent flags on parent command in order to inherit flags in
sub-commands. Turn on notary mode of morph client in `subnet` command of
admin utility for notary environments.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] morph/client: Get proxy contract address from NNS

Make `Client.EnableNotarySupport` method to call `NNSContractAddress`
for proxy contract if it is not specified in corresponding option.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit that referenced this issue


          [#979] adm/subnet: Always set group ID parameter in client cmds

3fcd7bc

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit that referenced this issue


          [#979] Upgrade SDK NeoFS Go dependency

6f41cd8

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit that referenced this issue


          [#979] adm/subnet: Fix print out of subnet info in get cmd

cc8a003

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit that referenced this issue


          [#979] adm/subnet: Rename id flag to admin in admin cmd

5f915df

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit that referenced this issue


          [#979] adm/subnet: Rename id flag to node in node cmd

dd2998d

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit that referenced this issue


          [#979] adm/subnet: Fix typos

1b69886

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] ir/subnet: Register parser and handler of RemoveNode …

c10eb59

…event

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] ir/subnet: Register parser and handler of RemoveNode …

d5dfb62

…event

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this issue


          [nspcc-dev#979] ir/subnet: Register parser and handler of RemoveNode …

3a1c5d1

…event

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

cthulhu-rider pushed a commit that referenced this issue


          [#979] ir/subnet: Register parser and handler of RemoveNode event

973e50a

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Deploy and update Subnet contract

0813b14

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Add subnet-related commands

30912d7

Add `subnet` command which contains all subnet-related commands. Add
sub-commands:
  * `create` for creation;
  * `remove` for removal;
  * `get` for reading;
  * `admin` for admin management;
  * `client` for client management.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Deploy missing contracts during updating

f5e368c

Make `nnsResolveHash` function to return declared error on `token not
found` fault exception. Catch this error in `deployContracts` method,
and switch to deployment if updating contract is missing.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Register NNS domain of the deployed contracts

242d660

Make `deployContracts` method to call `nnsRegisterDomain` in order to
register NNS domain for deployed contracts.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] morph/client: Get proxy contract address from NNS

266b9a6

Make `Client.EnableNotarySupport` method to call `NNSContractAddress`
for proxy contract if it is not specified in corresponding option.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm: Fix problems after testing

7b5f0e6

Use persistent flags on parent command in order to inherit flags in
sub-commands. Turn on notary mode of morph client in `subnet` command of
admin utility for notary environments.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] morph/client: Return zero values from CalculateNonceA…

64bca30

…ndVUB

Make `CalculateNonceAndVUB` to return zero values if notary isn't
enabled.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] ir/subnet: Fix notary event name of subnet creation

7e19c43

Notary event name equals to the name of the method which throws the
event.

Define name const of notary subnet creation.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm/subnet: Fix handling of non-notary flag in initCl…

400aba8

…ient

`initSubnetClient` must call `EnableNotarySupport` only if non-notary
flag is not set.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm/subnet: Inherit pre-run functions in child commands

15e58ee

Cobra commands don't call `PreRun` functions on parent by default. We
need to do it in `subnet` command of admin utility in order to inherit
viper bindings.

Add `inheritPreRun` function which makes sub-commands to call `PreRun`
functions before its own `PreRun`.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm/subnet: Add commands to add/remove nodes

d604764

Implement `ManageNodes` operation on morph subnet client.
 Add `node add` and `node remove` commands to `subnet` section.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm/subnet: Fix notary issues

5d94840

Only `subnet create` command can generate notary requests.

Remove global `non-notary` flag. Add `notary` flag to `create` cmd.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] ir/subnet: Fix notification event names

15d15c0

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm/subnet: Always set group ID parameter in client cmds

06640de

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] Upgrade SDK NeoFS Go dependency

af49ff9

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm/subnet: Fix print out of subnet info in get cmd

7d7898d

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm/subnet: Rename id flag to admin in admin cmd

121c30a

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm/subnet: Rename id flag to node in node cmd

5faf07f

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] adm/subnet: Fix typos

eadb5f5

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue


          [nspcc-dev#979] ir/subnet: Register parser and handler of RemoveNode …

09aa73c

…event

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment