add washtub client lib #9
Conversation
Changes: - Refactor Event - Fixing some config structure - Add readme
Fixing to run the service
* add docker-compose nsq services * fix tests http
Changes: - Refactor Event - Fixing some config structure - Add readme
* add docker-compose nsq services * fix tests http
| ports: | ||
| - "4150:4150" | ||
| - "4151:4151" | ||
| nsqadmin: |
There was a problem hiding this comment.
gak skalian washtubnya coach? wkwk
There was a problem hiding this comment.
tidak sesimpel itu, image reponhya mau tarok mana? beda pr aja
washtub/http/http.go
Outdated
| client *http.Client | ||
| } | ||
|
|
||
| func NewWashtuber(ctx context.Context, address string) (washtub.Washtuber, error) { |
There was a problem hiding this comment.
gw jadi ada ide, ini kan client washtub, dibikin pisah repo aja? wkwk
There was a problem hiding this comment.
kyknya timeout sama pulse intervalnya bisa diconfig in deh coach
There was a problem hiding this comment.
sama ChannelID better di define waktu new, karena akan selalu fix, jadi gausah di function
There was a problem hiding this comment.
consumer kan bisa banyak, tp init cuma sekali. mau gimana simpan channel id nya?
| type Washtuber interface { | ||
| Pulse(ctx context.Context, data entities.PulseRequest) chan error | ||
|
|
||
| Message(ctx context.Context, data entities.MessageRequest) (*entities.MessageResponse, error) |
There was a problem hiding this comment.
Menurut gw better LogMessage(body string, status string) error
channelID ambil dari washtub property
washtub/http/http.go
Outdated
| client *http.Client | ||
| } | ||
|
|
||
| func NewWashtuber(ctx context.Context, address string) (washtub.Washtuber, error) { |
There was a problem hiding this comment.
sama ChannelID better di define waktu new, karena akan selalu fix, jadi gausah di function
| ) | ||
|
|
||
| type Washtuber interface { | ||
| Pulse(ctx context.Context, data entities.PulseRequest) chan error |
There was a problem hiding this comment.
ini better gini gak coach?
Pulse(ctx context.Context) -> address dll ambil dari property washtuber, trus status auto true wkwk
yg ini, masuk ke init washtuber nya:
Address string json:"address"
Topic string json:"topic"
SinkType string json:"sink_type"
Status string json:"status"
naini wkwk knp tu yug? |
No description provided.