Add External output area #825
Conversation
|
"Love the sidecar. Keeps things tidy." - @ivanov |
|
As Kyle said, this looks great, @lgeiger! Another reasonable possibility for the outputs would be too keep adding them onto a single page on the left, and scroll down so that the last one comes into view... that way you can scroll down through them and see multiple (for example, if you're just printing one line per output, it'd be nice to see a bunch of them as opposed to having to click to page through them. On the other hand, the current implementation is perfect for comparing images, flipping back and forth between them, so there are use cases for both. |
|
@ivanov Thanks a lot for the feedback. Yeah I though about this too. I didn't go with it because a infinite scrolling list might become a bit messy with time, especially with multiple rich outputs. One thing to note is that we accumulate stdout (primarily for properly handling ANSI escapes):
I think this behavior is a good compromise between the ability of comparing multiple rich outputs while allowing users to read large amounts of stdout without constantly flipping through the history. |
lib/components/output-area.js
Outdated
|
|
||
| import typeof store from "../store"; | ||
|
|
||
| const OututArea = observer(({ store: { kernel } }: { store: store }) => { |
lib/components/output-area.js
Outdated
| ); | ||
| }); | ||
|
|
||
| export default OututArea; |
There was a problem hiding this comment.
I've had good results testing this out. Great work!
One thing I've been thinking about is how to handle having both watches and output panes open, ie could one or the other be pinned or should they split and use the same dock etc. But I agree there will probably be iterations from here.
|
@BenRussert The great thing about our new panels is that users can re-arange them however they like: Totally agree, this is only the start. I'm happy to explore different UI's (e.g. a long scrolling list, or different output areas for different mime types, etc.) |
|
@lgeiger we should save that gif for the release notes and docs |
This is a initial implementation of a external output display using docks:
If the output pane is present, output is redirected to this pane, only the spinner and status icons stay in the text editor.
I don't know what the best behavior for this panel would be. We can iterate one this an collect feedback from users.
Fixes #760