Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection of Gaijin Entertainment games #2311

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

0xA50C1A1
Copy link
Contributor

@0xA50C1A1 0xA50C1A1 commented Feb 8, 2024

Please sign (check) the below before submitting the Pull Request:

Describe changes:

NDPI_PROTOCOL_GAIJIN is common protocol ID for all Gaijin Entertainment games (mostly UDP and some TLS traffic).

Sadly I couldn't merge these two pcap files into one, cuz they have different headers or whatever.

Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@IvanNardi IvanNardi merged commit f5cec00 into ntop:dev Feb 9, 2024
32 of 33 checks passed
@0xA50C1A1 0xA50C1A1 deleted the new-app/gaijin-entertainment branch February 9, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants