Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EOF whitespace strip #126

Merged
merged 1 commit into from Feb 9, 2020
Merged

Fix EOF whitespace strip #126

merged 1 commit into from Feb 9, 2020

Conversation

@Crunkle
Copy link
Contributor

Crunkle commented Feb 8, 2020

Stripping EOF whitespace does not work outside of Unix formats. The pattern only needs the \n alone as it will match new lines on all file formats regardless of the actual <EOL> value written to the file.

Previously only stripping on Unix, now tested and working correctly on all formats after patch.

@Cimbali
Cimbali approved these changes Feb 9, 2020
Copy link
Collaborator

Cimbali left a comment

Good catch!

@Cimbali Cimbali merged commit 4afbd45 into ntpeters:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.