Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cheshire dependency #1

Closed
rfhayashi opened this issue Jan 24, 2020 · 1 comment
Closed

Add cheshire dependency #1

rfhayashi opened this issue Jan 24, 2020 · 1 comment

Comments

@rfhayashi
Copy link

To make client/request* work I needed to add cheshire to my project.clj. clj-http will not parse json unless you do that. I could make a pull request to do that, but wanted to know if you think it is best to add an instruction in the readme, add it as an actual dependency, or maybe I'm missing something. Since clj-github-app explicitly uses the json parsing, I'd be inclined to add it as an actual dependency.

By the way, thank you for the library :)

@philomates
Copy link
Contributor

I released this as a part of nubank/0.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants