Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style preferences #188

Open
erickisos opened this issue Jan 29, 2022 · 0 comments
Open

Code style preferences #188

erickisos opened this issue Jan 29, 2022 · 0 comments
Labels
documentation Missing documentation or improvements in the existing one

Comments

@erickisos
Copy link
Contributor

Hey everyone!

I'm looking at the code and I saw that there are some inconsistencies between code formatting, mainly in the usage of quotes (" on some strings and ' in other cases).
So what do you think about establishing some preferences on code style? I mean, we already have flake8 to check whether the code follows some PEP8 recommendations, but I want to be sure before adding extra elements or something that could break the current approach?

I know that we have this section and that we are following this guide and PEP8, so I just want to be sure that we are in the same channel.

Also if we don't want to start adding a lot of manual/custom rules, we can work directly with an unopinionated framework like black, which usually follows everything in the PEP8 (except for the double quotes).

Thanks in advance!

@erickisos erickisos added the documentation Missing documentation or improvements in the existing one label Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Missing documentation or improvements in the existing one
Projects
None yet
Development

No branches or pull requests

1 participant