Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observers should not raise #72

Open
MatthieuDartiailh opened this issue Oct 9, 2017 · 0 comments
Open

Observers should not raise #72

MatthieuDartiailh opened this issue Oct 9, 2017 · 0 comments
Milestone
1.0.0

Comments

@MatthieuDartiailh
Copy link
Member

Observers should not raise as it can lead to unexpected side effect. @sccolbert would prefer to follow the pattern adopted in phosphor and simply print the exception if one is raised. This is addressed by #71 which is pending review.
@MatthieuDartiailh MatthieuDartiailh added this to the 1.0.0 milestone Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@MatthieuDartiailh