Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEOS-1095] update docker compose scripts to check for open ports #1964

Closed
evisdrenova opened this issue May 14, 2024 · 2 comments
Closed

[NEOS-1095] update docker compose scripts to check for open ports #1964

evisdrenova opened this issue May 14, 2024 · 2 comments
Labels
good first issue Good for newcomers Improvement Created by Linear-GitHub Sync
Milestone

Comments

@evisdrenova
Copy link
Contributor

evisdrenova commented May 14, 2024

ran into an port issue when i ran docker compose -f compose.dev.yml because it was trying to stand up a db on 5435 but I was already using that port. Chris from Osmind had some of the same feedback when he was trying to stand us up locally - he had conflicts with an existing set up.

image.png

Would be nice to be able to continue to search for a port if it finds the first port is already allocated, a better user experience compared to the user having to go and update things. For me, I already had a DB that I was actively using on that port so it was annoying to have to update it to use a new port for the docker compose would work.

we can run an init script before any of the containers are created to check what ports are open and then dynamically update the following scripts with those ports. Would have to make sure that we also update the seed scripts with the right port number as well.

From SyncLinear.com | NEOS-1095

@evisdrenova evisdrenova added the Improvement Created by Linear-GitHub Sync label May 14, 2024
@evisdrenova evisdrenova changed the title [NEOS-1095] update compose scripts to check for open ports [NEOS-1095] update docker compose scripts to check for open ports May 14, 2024
@evisdrenova evisdrenova added the good first issue Good for newcomers label May 14, 2024
@evisdrenova evisdrenova added this to the v.20 milestone May 20, 2024
@nickzelei
Copy link
Member

I hear you on the open ports thing, however I think this is way more complex than it's worth.
A much simpler solution is to just change our default ports to something else.

Many examples on the internet use these ports which is why it is a conflict.

@evisdrenova
Copy link
Contributor Author

yeah agreed - might be nice to use some non-standard ports to try and avoid the issue…. until someone is using those ports 😅

@evisdrenova evisdrenova closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants