Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It can not start the server with nuekit 0.5.3, but works with nue 0.4.3 #253

Closed
xiejx618 opened this issue Apr 6, 2024 · 6 comments · Fixed by #268
Closed

It can not start the server with nuekit 0.5.3, but works with nue 0.4.3 #253

xiejx618 opened this issue Apr 6, 2024 · 6 comments · Fixed by #268
Labels

Comments

@xiejx618
Copy link

xiejx618 commented Apr 6, 2024

OS : windows 11 23H2(22631.3374)
bun:1.1.2

E:\admin-dashboard>bun install nuekit@0.4.3 --global
bun add v1.1.2 (c8d072c2)

installed nuekit@0.4.3 with binaries:

  • nue

1 package installed [31.00ms]

E:\admin-dashboard>nue

✓ Nue 0.4.3 • Bun 1.1.2
✓ Initialize ./.dist/dev: ••••••••••✓ Serving site from ./.dist/dev
✓ Building site to: ./.dist/dev

✓ Single-page apps 1
index.html

Time taken: 13ms

http://localhost:8080/
^C
E:\admin-dashboard>bun uninstall nuekit --global
bun remove v1.1.2 (c8d072c2)

  • nuekit
    1 package removed [15.00ms]

E:\admin-dashboard>bun install nuekit --global
bun add v1.1.2 (c8d072c2)

installed nuekit@0.5.3 with binaries:

  • nue

1 package installed [3.32s]

E:\admin-dashboard>nue

✓ Nue 0.5.3 • Bun 1.1.2
✓ Initialize ./.dist/dev: ••••••••••
✓ Building site to: ./.dist/dev

Time taken: 1ms

E:\admin-dashboard>

@kzt-wt
Copy link

kzt-wt commented Apr 6, 2024

I'm facing the same problem.

@nobkd
Copy link
Collaborator

nobkd commented Apr 7, 2024

@kzt-wt are you also using bun on windows?

I'll test it on Windows later today / when I find the time. Then, we'll see, if there is some Windows related code / bun problems :)

@kzt-wt
Copy link

kzt-wt commented Apr 7, 2024

Yes
I'm using bun on Windows.

@nobkd
Copy link
Collaborator

nobkd commented Apr 8, 2024

I was able to reproduce this unexpected behavior. Will have to check since which change this happens.
I also haven't checked yet, if it also happens for node on windows... (sorry for the slow progress, )

EDIT:
Happens for both node (with env shebang edited to node) and bun since nuekit 0.5.2
So 0.5.1 / 0.5.0 work fine, but some resources are not converted / found on serve I think...

@nobkd nobkd added the bug label Apr 8, 2024
@nobkd
Copy link
Collaborator

nobkd commented Apr 27, 2024

I made a git bisect and the first bad commit is 6a7464b (Simplified stats command), even when fixing the doubled function fmt and the wrong imports.
Will investigate further.

@nobkd
Copy link
Collaborator

nobkd commented Apr 27, 2024

Found the problem:

// build
else if (push || args.paths[0] || cmd == 'build') {

args.paths contains the path to the cli.js file on Windows, because it wasn't filtered.

Important

This issue is already fixed with #239, but not released yet...
Soo: Duplicate of #179

I will try making it more robust, but that's it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants