-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix DOM tests #284
Closed
Closed
test: fix DOM tests #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs: Fix typos
…esting test: use workspace package versions
chore(cli): make executable filtering more robust
chore: add issue templates
docs: update cli options help
chore: ignore coverage directory
fix: zero attr
fix: page router fixed and tests added - nuejs#263
Linux throws following error with node: 'TypeError: The feature watch recursively is unavailable on the current platform, which is being used to run Node.js'
later replace '@nue/page-router.js' with '@nue/view-transitions.js'
Important This should only be merged after |
This was referenced Jul 19, 2024
Reopening with less noise and more compact implementation Edit: See #285 |
I want to finish the dev branch first before merging any PR's from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the tests.
Only needs
@happy-dom/global-registrator
(and not@happy-dom/jest-environment
too)jest
globalAdditional changes: (sorry, for reviewing)
.editorconfig
actions/checkout@v4
.dist
package.json
sWarning
Only caveat is, that the following code has to be imported in each DOM test file:
But I think that's fine
Test run without merge from dev: https://github.com/nobkd/nue/actions/runs/9982211641