Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix DOM tests #284

Closed
wants to merge 41 commits into from
Closed

test: fix DOM tests #284

wants to merge 41 commits into from

Conversation

nobkd
Copy link
Collaborator

@nobkd nobkd commented Jul 17, 2024

This should fix the tests.

Only needs @happy-dom/global-registrator (and not @happy-dom/jest-environment too)

  • fix test running for single packages
  • simplify code for DOM testing
  • import jest global
  • simplify DOM test paths

Additional changes: (sorry, for reviewing)

  • add optional .editorconfig
  • run tests on all pull requests
  • use actions/checkout@v4
  • ignore .dist
  • order and format package.jsons

Warning

Only caveat is, that the following code has to be imported in each DOM test file:

import { GlobalRegistrator } from '@happy-dom/global-registrator'
GlobalRegistrator.register()

But I think that's fine


Test run without merge from dev: https://github.com/nobkd/nue/actions/runs/9982211641

nobkd and others added 30 commits March 28, 2024 01:21
…esting

test: use workspace package versions
chore(cli): make executable filtering more robust
chore: ignore coverage directory
@nobkd nobkd changed the title Test/fix dom test: fix DOM tests Jul 17, 2024
@nobkd nobkd mentioned this pull request Jul 17, 2024
@nobkd nobkd requested a review from tipiirai July 17, 2024 23:02
@nobkd nobkd changed the base branch from dev to master July 17, 2024 23:12
later replace '@nue/page-router.js' with '@nue/view-transitions.js'
@nobkd
Copy link
Collaborator Author

nobkd commented Jul 17, 2024

Important

This should only be merged after dev is merged into main OR merge this branch into dev, when the tests there work

@nobkd
Copy link
Collaborator Author

nobkd commented Jul 27, 2024

Reopening with less noise and more compact implementation

Edit: See #285

@tipiirai
Copy link
Contributor

tipiirai commented Aug 1, 2024

I want to finish the dev branch first before merging any PR's from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants