Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix DOM tests, create-cli test #285

Merged
merged 7 commits into from
Aug 14, 2024
Merged

Conversation

nobkd
Copy link
Collaborator

@nobkd nobkd commented Jul 27, 2024

TODO:

  • rebase on dev
  • fixing DOM tests (wrapped main content with article tag)
  • find reason for DOMException: This element has no parent node. (was mounting components twice)

Other:

  • simplify running tests
    • with Node: npm test or bun run test
    • with Bun: bun test
    • allow testing single package (when located at a sub-package's root)
  • update checkout & bun action version

@nobkd nobkd mentioned this pull request Jul 27, 2024
@nobkd

This comment has been minimized.

@nobkd

This comment was marked as outdated.

@nobkd nobkd changed the base branch from master to dev August 8, 2024 02:50
@nobkd nobkd marked this pull request as draft August 8, 2024 02:52
@nobkd nobkd force-pushed the test/fix-dom branch 4 times, most recently from 9266ff9 to 9f583e5 Compare August 8, 2024 20:01
@nobkd nobkd marked this pull request as ready for review August 8, 2024 21:35
@nobkd

This comment has been minimized.

@nobkd nobkd force-pushed the test/fix-dom branch 4 times, most recently from f842b0c to 3e19daf Compare August 11, 2024 20:39
@nobkd nobkd marked this pull request as draft August 13, 2024 15:56
@nobkd
Copy link
Collaborator Author

nobkd commented Aug 13, 2024

now based on #312

@nobkd nobkd changed the title test: fix DOM tests test: fix DOM tests, create-cli test Aug 13, 2024
@nobkd nobkd marked this pull request as ready for review August 13, 2024 20:58
@nobkd

This comment has been minimized.

@nobkd nobkd mentioned this pull request Aug 14, 2024
@nobkd
Copy link
Collaborator Author

nobkd commented Aug 14, 2024

Is ready for review.

Includes also changes to create cli command.

Will probably have to check if -C automatically creates the dir
Edit: it doesn't. Will have to ensure dir exists beforehand.

@tipiirai tipiirai merged commit 18f0b3b into nuejs:dev Aug 14, 2024
4 checks passed
@nobkd nobkd deleted the test/fix-dom branch August 14, 2024 03:47
@tipiirai
Copy link
Contributor

Awesome work again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants