Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize audio #329

Closed
loonies opened this issue May 9, 2019 · 5 comments
Closed

Normalize audio #329

loonies opened this issue May 9, 2019 · 5 comments
Labels
enhancement This thread requests an enhancement to be implemented.

Comments

@loonies
Copy link

loonies commented May 9, 2019

When playing tracks some are louder or quieter and I have to reach to volume control quite often. Think about audio filter that will normalize loudness.

Some ideas using ffmpeg

@nukeop nukeop added enhancement This thread requests an enhancement to be implemented. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. help wanted labels May 9, 2019
@c-jacquin
Copy link
Collaborator

c-jacquin commented Jun 5, 2019

We could modify this lib ffmpeg-normalize in order to use stream/buffer instead of file path and stream the normalized audio via the http api.

@nukeop
Copy link
Owner

nukeop commented Jun 5, 2019

Sounds like it'll be best to think about this after #335 and #342 so we can bundle it correctly on different systems.

@mlucas94
Copy link
Contributor

mlucas94 commented Jun 8, 2019

I would like to start working on this. The ideas and repository linked are enough to get an idea of how to implement it? Or is there anything else I should know about before I start?

@nukeop
Copy link
Owner

nukeop commented Jun 8, 2019

Thanks for offering the help. It's an open ended problem so feel free to approach it however you like. Remember that you'll need a way to bundle the required binaries on all platforms, and probably use the http api (look at how the local library streaming is implemented).

@nukeop nukeop removed the good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. label Jun 8, 2019
@nukeop
Copy link
Owner

nukeop commented Jun 8, 2019

I removed the "good first issue" tag since it might turn out to be quite complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This thread requests an enhancement to be implemented.
Projects
None yet
Development

No branches or pull requests

4 participants