-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite "Loading market listings" #8
Comments
Several questions:
|
|
Alright, I can't reproduce it. I've tested it on 3 different machines (Chrome + Firefox) and it's working on all of them. Maybe you can try it on another browser? |
Does anything related to an error show up in the developer's console (F12)? |
I don't think so, no, I have that as well and it's working fine here. If you manually enter that url in the browser, does that print anything that's related to your listings? |
yes, if I enter those urls to chrome or firefox, it does print info about my listings. |
Alright, so that's at least working then. I pretty much need someone with this issue that has some coding experience and can help me debug this. |
Hello, thanks for your great script. Also, the page navigation disappear : http://i.imgur.com/i3DO7HX.png |
Page navigation is removed as all listings are loaded, it's pointless. |
The page only lists 100 items : http://i.imgur.com/onUzqTi.png |
parseInt... http://i.imgur.com/hN2CnG6.png :P |
Fixing it and making it display 1000+ market items is very heavy at the moment anyway... |
Not working with firefox too :/ |
Here a quick-fix to apply : http://i.imgur.com/gO5V1O1.png but be aware page will be slow at beginning if you have lots of items on sale... |
Thanks, It's working now. But the relist button seems get removed, or is it just here ? |
so I just found a weird thing... hopefully this will helps you :) |
Alright, I don't have 1000+ items so I couldn't test that. I already had a function to replace non numbers so I've changed that. I have about 800 listings at market place without any performance issues (Firefox). Ideally I'd like to keep the pagination but this is problematic because the content is loaded async (every time to go to another page, even back) it's hard to show progress or any kind of feedback that's useful to the user. I think I can add some 3rd party pagination, I'll check it out later. Regarding the listings, I'm not sure why that happens with < 10 items. Did you find any reason why? |
I haven't looked for < 10 items yet. I have tested main market page. With 2000+ listed items. (thanks to your script !) Also, I found a typo... not sure how g_bmarketwindowhidden is working, though. |
Oh, and those buttons appear on Firefox... but not in Chrome http://i.imgur.com/3ptBGTP.png |
nope I didnt find anything, why < 10 items = infinite loading :( |
Firefox absolutely has a unminify option (Automatically black box minified sources). For some reason the injectJs code was put to lower case, not sure when that happened but it's an easy fix (already did that). I'll investigate the < 10 items bug too, I'll just have to remove all my 800 listings and try again, it's not that hard. I'm currently adding some pagination and a search for market listings, but I still need to style it. |
Please try out 3.5.0 :) |
niiiiiiice 👍 its working now |
Including < 10 items? |
yes, good job! 👍 |
It works quite well.
|
I'm not using Enhanced Steam, I already made some changes regarding sorting and ES but I'm not really looking into coding a ton of extra stuff just to get around it. I accept PRs for this if anyone is feeling up to it. Regarding the sorting: price is easy, as it's just a few numbers. sorting by name too (just using default js sort). Sort by date relies on Date.js, If there's a better library it shouldn't be too hard to use but I've yet to find one (+ localized preferably). It works rather well in English at least. The misplaced search box, there shouldn't be on for those listings, should be fixable. |
BTW, the maximum price is used for items that have no sell orders. Buy orders are only used if their price exceeds the calculated price (extremely unlikely) or if their price exceeds your maximum defined price (for example, you have the max set to 25 cents, a buy order wants to give 30 cents -> it will list it for 30 cents). This is the expected behavior and it's what I want, it doesn't make sense from an economic point of view to take your minimum price for example. |
I am talking about that kind of cases : http://i.imgur.com/jOSskWG.png About ES : |
Can you also send me one of these cards that's 100% certain causing issues? This should also be fixed then 👍 |
Fixed the search box, the rest seems to fixed in here. |
Hello. Just installed this extension, and I'm having this issue. |
yes, the issue < 10 = infinite loading is back :( |
yarushi lately too, but fixed it by resetting his browser. |
I'll investigate this again. |
I think I found the problem and have fixed it, will upload a new version in a sec. |
I would like to refresh my item prices but keep showing this "Loading market listings"
The text was updated successfully, but these errors were encountered: