Unit test all search results page components

[adamjarling]

Description

Write full, well documented unit tests for all search results page components.

Done Looks Like

Jest unit tests and mock api calls made for all search results page components.

blocked by #54

child of #276

[adamjarling]

This now refers to the Reactive Search results route: /reactivesearch The original search results view/route has been deleted.

[davidschober]

Is this currently "in progress" I think members of the team are actively working on search.

[adamjarling]

It's not yet "in progress". Since there's quite a few moving parts in the application, and a deadline to get this up & live in production, I've been slacking on writing tests the right way. Figure will pay back this technical debt in the next few weeks.

[davidschober]

@adamjarling I think these are stale. Ccan you confirm and close?

[adamjarling]

@davidschober I think all DC app unit test tickets can be closed, and known to be work that should be done when there's some room to prioritize it in.

[davidschober]

Sounds good. I’ll filter and close at will.

…

On Mar 20, 2019, at 10:58 AM, Adam J. Arling ***@***.***> wrote: @davidschober <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_davidschober&d=DwMCaQ&c=yHlS04HhBraes5BQ9ueu5zKhE7rtNXt_d012z2PA6ws&r=CoXnIwMRqWuZYP2-A0a5W0Zx7oTmsndVTaITZQwG-gg&m=kY0YR6YcmroMf3_G5kvDk6m9DJ4mbjYA54TRW5PLlVg&s=rrrZ4LlHcBTyiwORh_PcISynHdsdYSdwhAE-0Qt2C7I&e=> I think all DC app unit test tickets can be closed, and known to be work that should be done when there's some room to prioritize it in. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_nulib_next-2Dgen-2Dfront-2Dend-2Dreact_issues_47-23issuecomment-2D474900595&d=DwMCaQ&c=yHlS04HhBraes5BQ9ueu5zKhE7rtNXt_d012z2PA6ws&r=CoXnIwMRqWuZYP2-A0a5W0Zx7oTmsndVTaITZQwG-gg&m=kY0YR6YcmroMf3_G5kvDk6m9DJ4mbjYA54TRW5PLlVg&s=xD2GnyOAX3Bu9S7LIEIcndU17Gk9sh6orgN8ge4RYcU&e=>, or mute the thread <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AElKnkiKR-5FsE0d8u30WFW2KJO0lzY-5Fprks5vYlq3gaJpZM4VeqpN&d=DwMCaQ&c=yHlS04HhBraes5BQ9ueu5zKhE7rtNXt_d012z2PA6ws&r=CoXnIwMRqWuZYP2-A0a5W0Zx7oTmsndVTaITZQwG-gg&m=kY0YR6YcmroMf3_G5kvDk6m9DJ4mbjYA54TRW5PLlVg&s=nUBb6GiA0S_RHOjC9WC3HiGqckpxc7krDSjL3EgASJI&e=>.