Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error type stutter #20

Closed
Nemo157 opened this issue Nov 8, 2018 · 0 comments · Fixed by #31
Closed

Error type stutter #20

Nemo157 opened this issue Nov 8, 2018 · 0 comments · Fixed by #31

Comments

@Nemo157
Copy link
Member

Nemo157 commented Nov 8, 2018 •
edited
Loading

https://docs.rs/bs58/0.2.2/bs58/decode/enum.DecodeError.html

Should rename to bs58::decode::Error and add a deprecated alias, probably same with encode.
@Nemo157 Nemo157 mentioned this issue Aug 21, 2019
Merged
bors bot added a commit that referenced this issue Aug 21, 2019
@bors @Nemo157
Merge #31
f22b0d8 
31: Rename bs58::decode::DecodeError to remove stutter r=Nemo157 a=Nemo157

Fixes #20 

bors r+

Co-authored-by: Wim Looman <wim@nemo157.com>
bors bot added a commit that referenced this issue Aug 21, 2019
@bors @Nemo157
Merge #31
523b52b 
31: Rename bs58::decode::DecodeError to remove stutter r=Nemo157 a=Nemo157

Fixes #20 

bors r+

Co-authored-by: Wim Looman <wim@nemo157.com>
@bors bors bot closed this as completed in c8e0cef Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename bs58::decode::DecodeError to remove stutter Nemo157/bs58-rs
1 participant
@Nemo157