Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Python ETM: Apical segments on predicted cells are reused even if they're not matching #584

Closed
mrcslws opened this issue Jul 29, 2016 · 0 comments · Fixed by #585
Closed

Comments

@mrcslws
Copy link
Contributor

mrcslws commented Jul 29, 2016

There are a few big issues here:

  • Apical segments are never grown from predicted cells. They're only grown from bursting cells.
  • Apical segments on predicted cells will be reused during learning even when they aren't matching. Segments will be overused.
  • Additional bug: No learning happens if all of the cell's segments have 0 active synapses. This line should start with maxActiveSynapses = -1. Of course, this issue will go away when we start using the minThreshold.

This code needs to be much different: https://github.com/numenta/nupic.research/blob/5230a39e3adf9f62aa16d146ad8415d0bfb9f7da/htmresearch/algorithms/extended_temporal_memory.py#L425

It should find the best matching segment, and if there are no matching segments it should grow one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant