Resolution on unsigned >= 0 checks

[breznak]

enabled in -Wextra, for GCC:
comparison of unsigned expression >= 0 is always true [-Wtype-limits]

or on Clang: tautological compare warning.

We have NTA_CHECK( 0 <= var && var <= MAX) << "var is out of range! " serving as a gate. However the var is set to dattype unsigned int hence the warning. My question is: remove the var >= 0 condition and assume (IFF) someone decides to change var's type to signed to take care of the checking? Or we want to keep this, and place surpress #pragma to each relevant occurence? Or we just keep ignoring and mute Wtype-limits?

[breznak]

@scottpurdy do I take your comment (on some PR) as remove these mytype var >= 0 checks globally? If so, we can remove the Wno-type-limits flag and start fixing these. It'd be trivial but long..

[rhyolight]

@breznak Still a valid ticket?

[breznak]

yes, still waiting for advice from others before taking up the simple but
long work.

[rhyolight]

@scottpurdy Do you have any input?

[scottpurdy]

I support this.

[breznak]

logic moved to nupic.core

[rhyolight]

logic moved to nupic.core

@breznak what do you mean?

[breznak]

@rhyolight the c++ code is now in nupic.core repo, this issue is from '13. So I will just enable Wextra and call this closed.

[rhyolight]

So I will just enable Wextra and call this closed.

Is there a PR for this?

[breznak]

@rhyolight closing as the checks have been fixed somewhen inbetween. and Wextra added in numenta/nupic.core-legacy#273