Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Moved some linux-only logic from travis config to script. #1609

Merged
merged 3 commits into from
Dec 19, 2014

Conversation

rhyolight
Copy link
Member

No description provided.

@rhyolight
Copy link
Member Author

@scottpurdy This is one of the changes I made in #1579 that needed to be extracted.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 5e4d979 on rhyolight:travis-script-cleanup into 7b89abe on numenta:master.

sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test
sudo apt-get -qq update
sudo apt-get -qq install g++-4.8
alias gcc='gcc-4.8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this was the case before but seems really odd to alias this. Is setting CC/CXX below not sufficient?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but I'll test it out.

@rhyolight rhyolight self-assigned this Dec 11, 2014
@rhyolight
Copy link
Member Author

@scottpurdy Works without the aliases, good catch. Ready for merge.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.64%) when pulling f0f0c05 on rhyolight:travis-script-cleanup into 7b89abe on numenta:master.

@rhyolight
Copy link
Member Author

@scottpurdy Looks like the aliases are necessary: https://travis-ci.org/numenta/nupic/jobs/43780990

@coveralls
Copy link

Coverage Status

Coverage increased (+0.66%) when pulling a6614af on rhyolight:travis-script-cleanup into 7b89abe on numenta:master.

@rhyolight
Copy link
Member Author

@scottpurdy good to merge?

@scottpurdy
Copy link
Contributor

Sure re: merge. I don't think the alias is the right way to do this but that is unrelated to this PR.

@rhyolight
Copy link
Member Author

Restarted botched build...

rhyolight added a commit that referenced this pull request Dec 19, 2014
Moved some linux-only logic from travis config to script.
@rhyolight rhyolight merged commit a571ef3 into numenta:master Dec 19, 2014
@rhyolight rhyolight deleted the travis-script-cleanup branch December 19, 2014 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants