-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Moved some linux-only logic from travis config to script. #1609
Conversation
@scottpurdy This is one of the changes I made in #1579 that needed to be extracted. |
sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test | ||
sudo apt-get -qq update | ||
sudo apt-get -qq install g++-4.8 | ||
alias gcc='gcc-4.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize this was the case before but seems really odd to alias this. Is setting CC/CXX below not sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but I'll test it out.
@scottpurdy Works without the aliases, good catch. Ready for merge. |
@scottpurdy Looks like the aliases are necessary: https://travis-ci.org/numenta/nupic/jobs/43780990 |
@scottpurdy good to merge? |
Sure re: merge. I don't think the alias is the right way to do this but that is unrelated to this PR. |
Restarted botched build... |
Moved some linux-only logic from travis config to script.
No description provided.