Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcai dev #103

Merged
merged 12 commits into from
Apr 24, 2023
Merged

Xcai dev #103

merged 12 commits into from
Apr 24, 2023

Conversation

iintSjds
Copy link
Member

@iintSjds iintSjds commented Apr 22, 2023

  1. update for new version of BrillouinZoneMeshes.
  2. fixed a bug related to issue MeshGrid type #102

This pull request could test successful only after the new version of BrillouinZoneMeshes.jl published.

@iintSjds iintSjds linked an issue Apr 22, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #103 (f122a71) into dev (babad1c) will increase coverage by 1.45%.
The diff coverage is 92.30%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #103      +/-   ##
==========================================
+ Coverage   74.35%   75.81%   +1.45%     
==========================================
  Files          12       12              
  Lines         429      430       +1     
==========================================
+ Hits          319      326       +7     
+ Misses        110      104       -6     
Impacted Files Coverage Δ
src/meshgrids/common.jl 78.57% <87.50%> (+4.28%) ⬆️
src/meshgrids/MeshGrids.jl 100.00% <100.00%> (+57.14%) ⬆️
src/meshgrids/imfreq.jl 93.93% <100.00%> (-0.51%) ⬇️
src/meshgrids/imtime.jl 91.66% <100.00%> (-0.93%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iintSjds iintSjds merged commit 4869f61 into dev Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeshGrid type
3 participants