Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve omission of notebooks from nbval test collection #139

Closed
rossbar opened this issue Jul 16, 2022 · 0 comments · Fixed by #146
Closed

Improve omission of notebooks from nbval test collection #139

rossbar opened this issue Jul 16, 2022 · 0 comments · Fixed by #146
Labels
enhancement New feature or request

Comments

@rossbar
Copy link
Collaborator

rossbar commented Jul 16, 2022

There are some notebooks that we don't necessarily want to test when running nbval, e.g. notebooks from the contributor guide, non-executable articles, etc. Currently this is handled manually in the CI job by simply deleting the notebooks we want to test:

# TODO: find better way to exclude notebooks from test
rm content/tutorial-deep-reinforcement-learning-with-pong-from-pixels.ipynb
rm content/pairing.ipynb
rm content/tutorial-style-guide.ipynb
rm content/tutorial-nlp-from-scratch.ipynb

This is inelegant and doesn't translate well to local workflows (i.e. users who want to run pytest-nbval on their own machines). It'd be a nice improvement to do this more cleanly - perhaps via a pytest configuration option to ignore files during collection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant