Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add tox.ini to generize test setup #146

Merged
merged 8 commits into from
Dec 1, 2022
Merged

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Sep 8, 2022

This should help local testing, etc.

To close #141

It also addresses (potentially), and close #139

TODO (but opening the PR now to see whether this indeed works on GHA not just locally):

  • rethink the matrix and think about version combinations that make sense
  • add dev version testing to the matrix
  • use tox for the other CI configs, including building the HTML pages

@bsipocz
Copy link
Member Author

bsipocz commented Sep 8, 2022

hmm, tox -e test works locally, not sure what goes wrong with it (though in other projects I don't have multidimensional python version, but add that to the environment).

@bsipocz bsipocz marked this pull request as ready for review November 17, 2022 02:36
@bsipocz
Copy link
Member Author

bsipocz commented Nov 17, 2022

@rossbar @melissawm - Far from perfect, and finished, but maybe it's better to include more things (e.g. see the checkboxes above) into tox incrementally.

@bsipocz bsipocz added the infrastructure Issues relevant to infrasructure, rather than content label Dec 1, 2022
@bsipocz
Copy link
Member Author

bsipocz commented Dec 1, 2022

Let's get this in, we can always improve incrementally.

@bsipocz bsipocz merged commit 6efab8f into numpy:main Dec 1, 2022
@melissawm
Copy link
Member

Thanks, @bsipocz !!

@bsipocz bsipocz deleted the add_tox branch December 21, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues relevant to infrasructure, rather than content
Projects
None yet
2 participants