Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Dark mode syntax highlighting isn't as color-blind friendly as the light mode #21406

Closed
jakevandervaate opened this issue Apr 28, 2022 · 3 comments

Comments

@jakevandervaate
Copy link

Issue with current documentation:

Some of the syntax highlighting in the proposed dark mode switcher lacks the contrast present in the light mode. The best example I noticed was the json snippet on this page.

This is a follow up from the documentation meeting conversation with @MarsBarLee and @InessaPawson.

Original Images

The dark mode's green and orange lack contrast. The pink is harder to see as well.
Screenshot_20220428-082646

The light mode has more contrast in this example.
Screenshot_20220428-082708


Filtered Images

Here is the dark mode image with a green-weak filter to give an idea of what this may look like.
Screenshot_20220428-082646-green-weak

This is the dark mode image with a green-blind filter applied.
Screenshot_20220428-082646-green-blind

Idea or request for content:

No response

@rossbar
Copy link
Contributor

rossbar commented Apr 28, 2022

Thanks for the feedback @jakevandervaate ! It might be worth opening this issue upstream in the pydata-sphinx-theme project which is where this dark mode is implemented.

@seberg
Copy link
Member

seberg commented May 2, 2022

It would indeed be great to move this to the pydata-sphinx-theme and ping those interested there or reference it from here.

As far as I can tell, the dark-mode is not yet released, so it may be a great time to suggest changes to it in any case.

@jakevandervaate
Copy link
Author

Thanks for pointing me in the right direction @rossbar and @seberg! I opened this issue in pydata-sphinx-theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants