BUG: void dtype setup checked offset not actual pointer for alignment #11180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, silly me, the problem was that the macro is defined in the local file, and it was defined below... and I missed the first error ;). |
|
Maybe the macro should be moved all the way up, it is probably pretty random there. |
charris
reviewed
May 28, 2018
| @@ -760,7 +771,8 @@ _setup_field(int i, PyArray_Descr *descr, PyArrayObject *arr, | |||
| } | |||
|
|
|||
| ((PyArrayObject_fields *)(arr))->descr = new; | |||
| if ((new->alignment > 1) && ((offset % new->alignment) != 0)) { | |||
| if ((new->alignment > 1) && ( | |||
There was a problem hiding this comment.
The ( would look better on the next line.
There was a problem hiding this comment.
Committer can fix later if needed.
This commit also adds an assert and closes numpygh-11088
|
LGTM. |
charris
approved these changes
May 28, 2018
|
Thanks Sebastian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also adds an assert and closes gh-11088
Ok, the assert, its still in there with sizeof, which is probably OK here, but not right generally....