-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: move -std=c99 addition to CFLAGS to Azure config #12620
Conversation
The two TravisCI build matrix entry that have |
gcc 5.1 was only released in 2015; I think gcc 4.8 and 4.9 are still fairly extensively used. So only putting |
Seems to me like trying to automagically set compiler flags properly for people in the vast array of scenarios out there is asking for trouble compared to just documenting that we use C99 standard moving forward & directing issue reports to some brief documentation about this. So, I think I like the idea of just setting the C99 flags where needed in CI & documenting the requirement briefly (which is probably already done somewhere) as opposed to a programmatic interjection on compiler flags for pip, setup.py & so on. |
Note that |
Yes I know. It's exactly because it's required that I think that we should not add it to Instead, I think what we should do is one of:
Since there's not much precedent and it's not entirely clear how big a fraction of users/devs will be impacted, I'm not sure which of the two options is best. I think putting it in |
Okay I tried, there's no good way to do either as far as I can tell: rgommers@8aaf4d8. I think just moving it from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks sensible to me
Is there any distutils parallel to autoconf's |
@eric-wieser pretty sure there's not. That's why I tried to implement the check in the commit linked in the comment above. |
Thanks Ralf. |
See gh-12610 for details. Note, I removed this for TravisCI for now as a test, I want to see how big a problem we have for building from source at the moment.