Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Remove np.rank which has been deprecated for more than 5 years #14039

Merged
merged 1 commit into from
Jul 31, 2019
Merged

DEP: Remove np.rank which has been deprecated for more than 5 years #14039

merged 1 commit into from
Jul 31, 2019

Conversation

sameshl
Copy link
Contributor

@sameshl sameshl commented Jul 17, 2019

references #7059
xref #11521
@mattip I am still not sure if removing the function is the best choice. We could go ahead if you agree or we could also remove the warning and deprecated note entirely as you suggested

@charris
Copy link
Member

charris commented Jul 17, 2019

Expired deprecations need a release note.

@mattip mattip added 07 - Deprecation 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes labels Jul 17, 2019
@mattip
Copy link
Member

mattip commented Jul 17, 2019

Since #13908 is taking a while, perhaps just add a note to doc/release/1.18.0-notes.rst and we will refactor that file if/when #13908 lands

@sameshl
Copy link
Contributor Author

sameshl commented Jul 17, 2019

@mattip I am not able to debug why the builds are failing. Can you help me out?

@mattip
Copy link
Member

mattip commented Jul 17, 2019

Does python3 runtests.py pass for you?

@sameshl
Copy link
Contributor Author

sameshl commented Jul 18, 2019

@mattip While running python3 runtests.py, I am getting error

     from Cython.Compiler.Version import version as cython_version
     ModuleNotFoundError: No module named 'Cython'

`

@seberg
Copy link
Member

seberg commented Jul 18, 2019

@sameshl as the error suggests, you need Cython to build NumPy. Just installing it – through whatever channel you typically use – should work (we do require a fairly recent version, but that should not be an issue).

@sameshl
Copy link
Contributor Author

sameshl commented Jul 20, 2019

@mattip Let me know if any changes are required.

@seberg
Copy link
Member

seberg commented Jul 24, 2019

@sameshl, we are trying to change the way we do release notes. Can you move your note about this into a new file named changelog/14039.expired.rst? And yes, that can be a single line.

EDIT: Sorry, you have to rebase on master first, or the changelog folder will not exist.

@sameshl
Copy link
Contributor Author

sameshl commented Jul 25, 2019

Sure, will do that

@kritisingh1
Copy link
Member

xref #11521 as well. Sorry I didn't notice. Closing #14113 as duplicate

Deprecated ``np.rank`` removed
------------------------------

``np.rank`` has been removed. This was deprecated in numpy 1.10 and has been replaced by ``np.ndim``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat think last time around we just did a bullet point list here. Not sure it matters, I think I will just change it later (and then hope we actually do it like that) ;). Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Thanks!

@sameshl
Copy link
Contributor Author

sameshl commented Jul 29, 2019

@seberg Let me know if any more changes are required.

@seberg
Copy link
Member

seberg commented Jul 31, 2019

Rebased/squashed the commits together and made the release notes a bullet point. Merging, thanks.

@seberg seberg merged commit 453aa08 into numpy:master Jul 31, 2019
@sameshl sameshl deleted the remove_depr_rank_func branch July 31, 2019 18:57
@sameshl
Copy link
Contributor Author

sameshl commented Jul 31, 2019

Thanks @seberg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
07 - Deprecation 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants