-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: Remove np.rank which has been deprecated for more than 5 years #14039
Conversation
Expired deprecations need a release note. |
@mattip I am not able to debug why the builds are failing. Can you help me out? |
Does |
@mattip While running
` |
@sameshl as the error suggests, you need Cython to build NumPy. Just installing it – through whatever channel you typically use – should work (we do require a fairly recent version, but that should not be an issue). |
@mattip Let me know if any changes are required. |
@sameshl, we are trying to change the way we do release notes. Can you move your note about this into a new file named EDIT: Sorry, you have to rebase on master first, or the changelog folder will not exist. |
Sure, will do that |
changelog/14039.expired.rst
Outdated
Deprecated ``np.rank`` removed | ||
------------------------------ | ||
|
||
``np.rank`` has been removed. This was deprecated in numpy 1.10 and has been replaced by ``np.ndim``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat think last time around we just did a bullet point list here. Not sure it matters, I think I will just change it later (and then hope we actually do it like that) ;). Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Thanks!
@seberg Let me know if any more changes are required. |
Rebased/squashed the commits together and made the release notes a bullet point. Merging, thanks. |
Thanks @seberg ! |
references #7059
xref #11521
@mattip I am still not sure if removing the function is the best choice. We could go ahead if you agree or we could also remove the warning and deprecated note entirely as you suggested