-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Update travis.yml #14915
TST: Update travis.yml #14915
Conversation
96c9527
to
949e6c5
Compare
i think it is good to thoroughly test one version. Is there a way to collapse all the python3.7 tests into one environment with many jobs to make it clear this is on purpose? |
The different tests are run with different environment variables so NumPy still needs to be rebuilt. I think building and testing takes up most of the time. The pickle test should be covered by default in 3.8, so that probably doesn't need to be there. There may be some other tests that can be eliminated or combined but I don't want to experiment with those things in this PR. This is just to get the tests ready for the 1.8 branch. |
I've posted on the list for a discussion of tests we might want to eliminate. |
A bunch of resize tests are failing on Python3.7. Any idea why?
Seems to have come in in #12121. |
My guess is that the refcheck in the code is failing in 3.7. Trying now with 3.8 to see if that is still the case. |
I think there is some strange interaction between |
Just to summarize, the resize tests fail on 3.7 and 3.8, but pass on 3.6. The pytest, wheel, setup, etc. versions are all the same. The official wheel builds pass on all versions. @mattip Yeah, it is probably one of the "extras" in that test run. |
It is |
@mattip Thanks for tracking that down. How did you determine that? |
|
It must be some kind of meta-programming, I don't see where coverage changes any of what I claim it does, but the refcount is definitely 3 in the gdb debugger |
Here is an issue CPython had with coverage and refcounts, but they closed it in 2011 |
Given the Python dependency, I'm going to guess that something in |
The short term fix looks to be using 3.6 for that test, that gives us some time to deal with the problem. |
8c45be6
to
e5600ff
Compare
@@ -71,24 +78,30 @@ matrix: | |||
- NPY_BLAS_ORDER=mkl,blis,openblas,atlas,accelerate,blas | |||
- NPY_LAPACK_ORDER=MKL,OPENBLAS,ATLAS,ACCELERATE,LAPACK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone know why these environmental variables were added? I don't think we use any of those.
e5600ff
to
85002cf
Compare
Rebased. |
85002cf
to
8a82fbd
Compare
- Use 3.8 instead of 3.8-dev - Add some blank lines for clarity
8a82fbd
to
8175d8f
Compare
Perhaps we should spread the other tests across more Python versions?