MAINT: Clarify the error message for resize failure

[kngwyu]

Curerntly

>>> arr = np.array([1, 2, 3])
>>> arr_ref = arr
>>> arr.resize(100)

causes this error.

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: cannot resize an array that references or is referenced
by another array in this way.  Use the resize function

But, I feel it odd to tell users to use resize, when resize fails.

[eric-wieser]

The wording is "use the resize function", not "use the resize method". Perhaps it would be clearer to say use the np.resize function

reshape is not a substitute for resize.

[kngwyu]

Thanks, I changed to just propose np.resize or refcheck=False.

[eric-wieser]

This is not correct - passing refcheck = False doesn't help if PyArray_BASE(arr) is set.

Either:

• remove the remark about refcheck
• Split this if into two ifs, and only mention refcheck in the one where refcnt > 2 is true.

[kngwyu]

Thanks, fixed by the later way.

[eric-wieser]

As a follow up, you could move this check to be done before the other two. As you have it, there are cases where the user sees "A is not allowed, try B or C", then tries B and gets "B is not allowed, try C". If you move this check first, then the user will see "A is not allowed, try C", and fix it in one step.

[kngwyu]

Thanks, applied your advice.

[eric-wieser]

Would be great to add a test for that code path that codecov complains about. Creating a weakref to the array then trying to resize it should do the trick.

[kngwyu]

Thanks. Please let me know if test location is wrong.

[eric-wieser]

Looks good assuming tests pass

[mattip]

Thanks @kngwyu

[charris]

Fails for wheel tests on Python 3.7. See here.