-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Deduplication with abstract class #16839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing: TypeError: metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases
. You might want to run python setup.py build_ext
locally before resubmitting.
@@ -15,7 +17,45 @@ def show_fortran_compilers(_cache=None): | |||
dist = distutils.core._setup_distribution | |||
show_fcompilers(dist) | |||
|
|||
class config_fc(Command): | |||
class config(Command, metaclass=abc.ABC): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While distutils uses lower-case classes, I think we should use Upper-case. This will require more changes through the file ...
class config(Command, metaclass=abc.ABC): | |
class Config(Command, metaclass=abc.ABC): |
It's probably simplest to avoid using |
@marload Thank you for working on this! Do you think you could finish the PR some time soon? |
|
config_cc and config_fc inherit abstract class config.