-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: py3k: remove os.fspath and os.PathLike backports #17473
Conversation
Could you show an example of how this exception now looks? It should be easy to call this code with an object that trips it. |
This entire function is completely unreachable - we should just remove it. |
The error stack basically looks the same as before:
|
Should I remove the function instead? |
The condition |
Updated based on comment |
Hi, I am having difficulties trying to run the failing tests locally, |
You may find this doc useful: https://numpy.org/doc/stable/dev/development_environment.html#running-tests |
The failures are unrelated, let's try rerunning |
Thanks @zer0link! |
os_fspath = os.fspath | ||
os_PathLike = os.PathLike |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're looking to make another contribution, it would be great if we could find all the places that use np.compat.os_PathLike
and replace them with os.PathLike
.
Thanks @eric-wieser , was trying to debug the issue for some time now |
Related to #15986 .
Chain exceptions in "py3k.py" corresponding to exceptions on line 173 as mentioned in this comment.