ENH, BLD: Add windows arm64 support #17804
Conversation
The macro _M_ARM64 can be used to detect ARM64 processor when using Visual Studio 2017 or greater. More info: https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160
Use __umulh for Visual Studio build on Windows ARM64. ARM64 intrisic info: https://docs.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics?view=msvc-160
ader1990
force-pushed
the
add_windows_arm64_support
branch
from
dd2f887
to
a700422
Compare
Well, in the sense that there were multiple solutions presented on that issue (like future x64 emulation). Of course, I think the native build solution would be the best. |
charris
changed the title
| * _M_ARM64 is defined by VS compiler >= 2017 to build native | ||
| * ARM64 packages on Windows | ||
| */ | ||
| #define NPY_CPU_ARMEL_AARCH64 |
There was a problem hiding this comment.
why ARMEL_AARCH64 ? and not MSVC_AARCH64?
There was a problem hiding this comment.
As this is for endianess check, the closest was armel_aarch64.
| #pragma intrinsic(__umulh) | ||
| static NPY_INLINE uint64_t mulhilo64(uint64_t a, uint64_t b, uint64_t *hip) { | ||
| uint64_t p0 = a * b; | ||
| uint64_t p1 = __umulh(a, b); |
There was a problem hiding this comment.
Is this an intrnisic newly defined for arm64 + MSVC? Is there a parallel intrinsic for arm64 + gcc?
There was a problem hiding this comment.
Here is the general definition: https://docs.microsoft.com/en-us/cpp/intrinsics/umulh?view=msvc-160
And it is present as an arm64 intrinsic: https://docs.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics?view=msvc-160
I do not know if there is one for arm+gcc.
There was a problem hiding this comment.
Is this better on AMD64 than using _umul128 directly?
|
FYI, there are "unofficial official" releases of CPython for ARM64 at https://dev.azure.com/Python/cpython/_build?definitionId=21 (browse to a build result, then "Artifacts" and you probably want "layout_full_arm64"). When numpy is ready to claim support for ARM64, I'll be happy to make them official CPython releases. But I don't want you guys to feel like you've been forced into it, which is why I'm holding off for now (and simultaneously trying to get some CI hardware for you... but that's a bit 😫...) |
Unfortunately, I do not have access to those artifacts. The builds I created using github pipelines should be practically the same with those from that artifact store. Example of build produced using github actions for tag v3.9.0: https://github.com/ader1990/cpython-builder/actions/runs/377798403 . I have tested that build with this numpy patch and it works perfectly. |
|
You can't even download them from the "..." at the right? That ought to work without signing in... Either way, the main difference should just be that these ones are signed (and will match every release made from python.org). |
Let me be careful here... there is progress, but there is no update... yeah I think I can say that much. :) |
Added support for building numpy for Windows ARM64:
Test results:
You need a tweaked version of the msvc compiler for Python, which you can download from here: https://github.com/ader1990/CPython-Windows-ARM64/releases
Source code for Python 3.8.5: https://github.com/ader1990/cpython/tree/v3.8.5-win-arm64 (basically is just a hack to recognise the emulated build tools for ARM64). You can rebase the commit that fixes the build on recent Python versions too: ader1990/cpython@b8c59c9
This fix is an alternative solution for #17747